Bug 1973525: [on-prem] Drop runlevel from infra namespaces by cybertron · Pull Request #2627 · openshift/machine-config-operator

cybertron · 2021-06-18T20:53:21Z

This appears to have been copy-pasta from the MCO namespace, but we
don't need it for the on-prem services.

- What I did

- How to verify it

- Description for the changelog
Dropped the runlevel specifier for the on-prem namespaces. It was not necessary and may have caused confusion about the services running in the namespace.

This appears to have been copy-pasta from the MCO namespace, but we don't need it for the on-prem services.

openshift-ci · 2021-06-18T20:53:24Z

@cybertron: This pull request references Bugzilla bug 1973525, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1973525: [on-prem] Drop runlevel from infra namespaces

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cybertron · 2021-06-18T20:55:39Z

/bugzilla refresh
/test e2e-openstack
/test e2e-ovirt
/test e2e-vsphere
/cc @mandre @Gal-Zaidman @jcpowermac @patrickdillon

openshift-ci · 2021-06-18T20:55:46Z

@cybertron: This pull request references Bugzilla bug 1973525, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @mike-nguyen

Details

In response to this:

/bugzilla refresh
/test e2e-openstack
/test e2e-ovirt
/test e2e-vsphere
/cc @mandre @Gal-Zaidman @jcpowermac @patrickdillon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kikisdeliveryservice

Adding approve and hold remove hold once you get the lgtms you need =)

/hold

Gal-Zaidman · 2021-06-21T07:20:57Z

/lgtm

mandre

/test e2e-openstack
LGTM provided e2e-openstack comes back green.

yuvalk · 2021-07-02T08:10:34Z

my PR is probably a dup
#2655
but
I think you've missed the run-level 1 for openshift-machine-config-operator

cybertron · 2021-07-02T21:54:47Z

my PR is probably a dup
#2655
but
I think you've missed the run-level 1 for openshift-machine-config-operator

Possibly. This change came out of a conversation about the infra namespaces, which clearly did not need the runtime attribute. I'm not certain whether that's the case for MCO itself.

cybertron · 2021-07-22T18:36:55Z

/retest

cybertron · 2021-08-18T14:44:26Z

/hold cancel

All affected platforms are passing and we have signoff from 3 of them. Let's get this in.

jcpowermac · 2021-08-18T14:52:38Z

/lgtm

openshift-ci · 2021-08-18T14:53:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, Gal-Zaidman, jcpowermac, kikisdeliveryservice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cybertron · 2021-08-20T14:25:04Z

/retest

openshift-bot · 2021-08-21T14:51:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-21T15:04:47Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-21T18:30:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-21T18:54:43Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-21T19:06:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-21T19:18:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-21T19:42:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-21T20:06:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-21T20:30:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-08-21T20:38:32Z

@cybertron: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/okd-e2e-aws	`be24a23`	link	`/test okd-e2e-aws`
ci/prow/e2e-aws-single-node	`be24a23`	link	`/test e2e-aws-single-node`
ci/prow/e2e-aws-disruptive	`be24a23`	link	`/test e2e-aws-disruptive`
ci/prow/e2e-aws-upgrade-single-node	`be24a23`	link	`/test e2e-aws-upgrade-single-node`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-08-21T21:30:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-21T21:42:43Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-21T21:54:43Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-21T22:42:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-21T22:54:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-21T23:06:45Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-21T23:42:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-21T23:54:45Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-08-22T01:16:42Z

@cybertron: All pull requests linked via external trackers have merged:

openshift/machine-config-operator#2627

Bugzilla bug 1973525 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1973525: [on-prem] Drop runlevel from infra namespaces

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[on-prem] Drop runlevel from infra namespaces

be24a23

This appears to have been copy-pasta from the MCO namespace, but we don't need it for the on-prem services.

openshift-ci Bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 18, 2021

openshift-ci Bot requested review from kikisdeliveryservice and sinnykumari June 18, 2021 20:53

openshift-ci Bot requested review from Gal-Zaidman, jcpowermac, mandre and patrickdillon June 18, 2021 20:55

openshift-ci Bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 18, 2021

openshift-ci Bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 18, 2021

openshift-ci Bot requested a review from mike-nguyen June 18, 2021 20:55

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2021

kikisdeliveryservice approved these changes Jun 18, 2021

View reviewed changes

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2021

openshift-ci Bot assigned Gal-Zaidman Jun 21, 2021

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2021

mandre reviewed Jun 24, 2021

View reviewed changes

kikisdeliveryservice mentioned this pull request Jul 2, 2021

Bug 1978581: remove run-level info from operators namespaces #2655

Merged

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2021

openshift-ci Bot assigned jcpowermac Aug 18, 2021

openshift-merge-robot merged commit 5e8471d into openshift:master Aug 22, 2021

Conversation

cybertron commented Jun 18, 2021

Uh oh!

openshift-ci Bot commented Jun 18, 2021

Uh oh!

cybertron commented Jun 18, 2021

Uh oh!

openshift-ci Bot commented Jun 18, 2021

Uh oh!

kikisdeliveryservice left a comment

Choose a reason for hiding this comment

Uh oh!

Gal-Zaidman commented Jun 21, 2021

Uh oh!

mandre left a comment

Choose a reason for hiding this comment

Uh oh!

yuvalk commented Jul 2, 2021

Uh oh!

cybertron commented Jul 2, 2021

Uh oh!

cybertron commented Jul 22, 2021

Uh oh!

cybertron commented Aug 18, 2021

Uh oh!

jcpowermac commented Aug 18, 2021

Uh oh!

openshift-ci Bot commented Aug 18, 2021

Uh oh!

cybertron commented Aug 20, 2021

Uh oh!

openshift-bot commented Aug 21, 2021

Uh oh!

openshift-bot commented Aug 21, 2021

Uh oh!

openshift-bot commented Aug 21, 2021

Uh oh!

openshift-bot commented Aug 21, 2021

Uh oh!

openshift-bot commented Aug 21, 2021

Uh oh!

openshift-bot commented Aug 21, 2021

Uh oh!

openshift-bot commented Aug 21, 2021

Uh oh!

openshift-bot commented Aug 21, 2021

Uh oh!

openshift-bot commented Aug 21, 2021

Uh oh!

openshift-ci Bot commented Aug 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Aug 21, 2021

Uh oh!

openshift-bot commented Aug 21, 2021

Uh oh!

openshift-bot commented Aug 21, 2021

Uh oh!

openshift-bot commented Aug 21, 2021

Uh oh!

openshift-bot commented Aug 21, 2021

Uh oh!

openshift-bot commented Aug 21, 2021

Uh oh!

openshift-bot commented Aug 21, 2021

Uh oh!

openshift-bot commented Aug 21, 2021

Uh oh!

openshift-ci Bot commented Aug 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

openshift-ci Bot commented Aug 21, 2021 •

edited

Loading