Update library-go for support out-of-tree Azure provider#2669
Update library-go for support out-of-tree Azure provider#2669openshift-merge-robot merged 2 commits intoopenshift:masterfrom lobziik:library-go-bump
Conversation
|
/lgtm |
|
/retest |
|
@lobziik: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
kikisdeliveryservice
left a comment
kikisdeliveryservice
left a comment
There was a problem hiding this comment.
1 question :)
| } | ||
|
|
||
| external, err := cloudprovider.IsCloudProviderExternal(cfg.Infra.Status.PlatformStatus.Type, cfg.FeatureGate) | ||
| external, err := cloudprovider.IsCloudProviderExternal(cfg.Infra.Status.PlatformStatus, cfg.FeatureGate) |
There was a problem hiding this comment.
For my own info, can you explain this change?
There was a problem hiding this comment.
We had to change the signature of the upstream method to include more information from the Infrastructure resource to allow the method to determine whether it is on a special cloud, in this case Azure stack hub (this also applies for things like gov clouds etc), where the platform shows up as Azure, but the designation that this is Azure Stack Hub is only available by looking at the Azure specific fields on the PlatformStatus. We don't expect this to change again in the future as we now have access to all of the provider specific statuses to make the decision needed in the future
There was a problem hiding this comment.
thanks for the details @JoelSpeed makes sense to me.
There was a problem hiding this comment.
kikisdeliveryservice
left a comment
kikisdeliveryservice
left a comment
There was a problem hiding this comment.
Changes make sense and are in line with library-go changes for Azure
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fedosin, JoelSpeed, kikisdeliveryservice, lobziik The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
5 participants
Updated library-go dependency with changes from openshift/library-go#1077. Needed for proceeding with Azure/AzureStackHub out of tree providers related work.