templates: add apiserver-url.env file for Azure workers#2671
templates: add apiserver-url.env file for Azure workers#2671Fedosin wants to merge 1 commit intoopenshift:masterfrom
Conversation
Azure node controller needs to know the URL of the internal apiserver load balancer. To do it, this commit creates an environment file with required env variables, that can be consumed by the controller. This approach is similar to what we do on master nodes: openshift#2232
|
/lgtm Thanks Mike |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Fedosin, JoelSpeed The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test e2e-upgrade-azure Can you please test it locally and let us know here that this is working as intended ? |
|
@sinnykumari: The specified target(s) for
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-azure |
|
@Fedosin: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@Fedosin @JoelSpeed this is passing can i merge? |
|
@kikisdeliveryservice yes please |
|
@Fedosin Why was this closed? Is it no longer needed? |
Azure node controller needs to know the URL of the internal apiserver load balancer.
To do it, this commit creates an environment file with required env variables, that can be consumed by the controller.
This approach is similar to what we do on master nodes:
#2232