Skip to content

templates: add apiserver-url.env file for Azure workers#2671

Closed
Fedosin wants to merge 1 commit intoopenshift:masterfrom
Fedosin:apiserver_url_env
Closed

templates: add apiserver-url.env file for Azure workers#2671
Fedosin wants to merge 1 commit intoopenshift:masterfrom
Fedosin:apiserver_url_env

Conversation

@Fedosin
Copy link
Copy Markdown
Contributor

@Fedosin Fedosin commented Jul 9, 2021

Azure node controller needs to know the URL of the internal apiserver load balancer.

To do it, this commit creates an environment file with required env variables, that can be consumed by the controller.

This approach is similar to what we do on master nodes:
#2232

Azure node controller needs to know the URL of the internal apiserver
load balancer.

To do it, this commit creates an environment file with required env
variables, that can be consumed by the controller.

This approach is similar to what we do on master nodes:
openshift#2232
@openshift-ci openshift-ci Bot requested review from sinnykumari and yuqi-zhang July 9, 2021 12:36
@JoelSpeed
Copy link
Copy Markdown
Contributor

/lgtm

Thanks Mike

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 9, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Fedosin, JoelSpeed
To complete the pull request process, please assign yuqi-zhang after the PR has been reviewed.
You can assign the PR to them by writing /assign @yuqi-zhang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sinnykumari
Copy link
Copy Markdown
Contributor

/test e2e-upgrade-azure

Can you please test it locally and let us know here that this is working as intended ?

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 9, 2021

@sinnykumari: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test cluster-bootimages
  • /test e2e-agnostic-upgrade
  • /test e2e-aws
  • /test e2e-aws-disruptive
  • /test e2e-aws-proxy
  • /test e2e-aws-serial
  • /test e2e-aws-single-node
  • /test e2e-aws-upgrade
  • /test e2e-aws-upgrade-single-node
  • /test e2e-aws-workers-rhel7
  • /test e2e-azure
  • /test e2e-azure-upgrade
  • /test e2e-gcp-op
  • /test e2e-gcp-op-single-node
  • /test e2e-gcp-single-node
  • /test e2e-gcp-upgrade
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-openstack
  • /test e2e-openstack-parallel
  • /test e2e-ovirt
  • /test e2e-ovirt-upgrade
  • /test e2e-ovn-step-registry
  • /test e2e-vsphere
  • /test e2e-vsphere-upgrade
  • /test e2e-vsphere-upi
  • /test images
  • /test okd-e2e-aws
  • /test okd-e2e-gcp-op
  • /test okd-e2e-upgrade
  • /test okd-e2e-vsphere
  • /test okd-images
  • /test unit
  • /test verify

Use /test all to run the following jobs:

  • pull-ci-openshift-machine-config-operator-master-e2e-agnostic-upgrade
  • pull-ci-openshift-machine-config-operator-master-e2e-aws
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-disruptive
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-serial
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-upgrade-single-node
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-workers-rhel7
  • pull-ci-openshift-machine-config-operator-master-e2e-gcp-op
  • pull-ci-openshift-machine-config-operator-master-e2e-gcp-op-single-node
  • pull-ci-openshift-machine-config-operator-master-e2e-metal-ipi
  • pull-ci-openshift-machine-config-operator-master-e2e-ovn-step-registry
  • pull-ci-openshift-machine-config-operator-master-e2e-vsphere-upgrade
  • pull-ci-openshift-machine-config-operator-master-images
  • pull-ci-openshift-machine-config-operator-master-okd-e2e-aws
  • pull-ci-openshift-machine-config-operator-master-okd-images
  • pull-ci-openshift-machine-config-operator-master-unit
  • pull-ci-openshift-machine-config-operator-master-verify
Details

In response to this:

/test e2e-upgrade-azure

Can you please test it locally and let us know here that this is working as intended ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sinnykumari
Copy link
Copy Markdown
Contributor

/test e2e-azure
/test e2e-azure-upgrade

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 9, 2021

@Fedosin: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/okd-e2e-aws 809d150 link /test okd-e2e-aws
ci/prow/e2e-aws-upgrade-single-node 809d150 link /test e2e-aws-upgrade-single-node
ci/prow/e2e-aws-workers-rhel7 809d150 link /test e2e-aws-workers-rhel7
ci/prow/e2e-aws-disruptive 809d150 link /test e2e-aws-disruptive
ci/prow/e2e-metal-ipi 809d150 link /test e2e-metal-ipi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kikisdeliveryservice kikisdeliveryservice requested review from kikisdeliveryservice and removed request for yuqi-zhang September 28, 2021 18:19
@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

@Fedosin @JoelSpeed this is passing can i merge?

@JoelSpeed
Copy link
Copy Markdown
Contributor

@kikisdeliveryservice yes please

@Fedosin Fedosin closed this Oct 13, 2021
@JoelSpeed
Copy link
Copy Markdown
Contributor

@Fedosin Why was this closed? Is it no longer needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants