Updating openshift libraries by kwoodson · Pull Request #2772 · openshift/machine-config-operator

kwoodson · 2021-09-22T15:27:33Z

Updating Openshift api, library-go, and client-go libraries.

kwoodson · 2021-09-22T16:36:53Z

Fixed the feature gate tests. unit tests now pass.

kwoodson · 2021-09-22T17:04:53Z

Looks like the e2e-agnostic-upgrade is failing because of quota.

The directory object quota limit for the Tenant has been exceeded. Please ask your administrator to increase the quota limit or delete objects to reduce the used quota."

kwoodson · 2021-09-22T17:41:51Z

/test e2e-agnostic-upgrade

kikisdeliveryservice

Can you explicitly say in the commit what libraries you are updating? ie openshift/api client-go library-go??

kikisdeliveryservice · 2021-09-23T17:27:14Z

@rphillips FYI

openshift/api openshift/client-go openshift/library-go

kwoodson · 2021-09-23T23:57:15Z

@kikisdeliveryservice I've updated the commit message to include the library names.

sinnykumari · 2021-09-27T15:09:03Z

PTAL since this PR adds explicitly PodSecurity: true into kubelet cofnig.
/assign @rphillips

rphillips · 2021-09-27T16:47:49Z

/hold for discussion around PodSecurity on by default in openshift/api (alpha level feature)

rphillips · 2021-09-27T17:28:47Z

/hold cancel
/lgtm

this feature flag only changes the API server.

openshift-ci · 2021-09-28T08:48:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwoodson, rphillips, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-09-28T09:14:14Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-28T10:02:13Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-28T10:26:12Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-28T10:38:19Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-28T10:50:14Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-28T11:14:14Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-28T11:50:13Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-28T12:02:14Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-28T12:26:25Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-28T12:38:14Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-28T13:14:13Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-28T14:38:14Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-28T15:02:14Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-28T15:38:19Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-28T15:50:16Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-28T16:27:15Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-28T16:39:15Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-28T16:52:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-28T17:05:14Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-28T17:17:15Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-28T17:41:13Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-28T18:05:14Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-28T19:05:16Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-28T19:17:15Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-28T19:29:16Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-28T20:06:15Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-28T20:43:00Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-09-28T21:12:58Z

@kwoodson: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-e2e-aws	`93b6a30`	link	false	`/test okd-e2e-aws`
ci/prow/e2e-aws-upgrade-single-node	`93b6a30`	link	false	`/test e2e-aws-upgrade-single-node`
ci/prow/e2e-aws-techpreview-featuregate	`93b6a30`	link	false	`/test e2e-aws-techpreview-featuregate`
ci/prow/e2e-vsphere-upgrade	`93b6a30`	link	false	`/test e2e-vsphere-upgrade`
ci/prow/e2e-aws-workers-rhel7	`93b6a30`	link	false	`/test e2e-aws-workers-rhel7`
ci/prow/e2e-aws-workers-rhel8	`93b6a30`	link	false	`/test e2e-aws-workers-rhel8`
ci/prow/e2e-aws-serial	`93b6a30`	link	false	`/test e2e-aws-serial`
ci/prow/e2e-ovn-step-registry	`93b6a30`	link	false	`/test e2e-ovn-step-registry`
ci/prow/e2e-aws-disruptive	`93b6a30`	link	false	`/test e2e-aws-disruptive`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-09-28T22:42:59Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-28T22:55:00Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-28T23:43:06Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci Bot requested review from kikisdeliveryservice and sinnykumari September 22, 2021 15:28

kwoodson force-pushed the api_bump branch 2 times, most recently from b0591d4 to 735ceaf Compare September 22, 2021 16:31

kikisdeliveryservice suggested changes Sep 23, 2021

View reviewed changes

Comment thread templates/master/01-master-kubelet/_base/files/kubelet.yaml Outdated

Copy link
Copy Markdown

Contributor

kikisdeliveryservice Sep 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rphillips FYI

Updating the following openshift libraries:

93b6a30

openshift/api openshift/client-go openshift/library-go

kwoodson force-pushed the api_bump branch from 735ceaf to 93b6a30 Compare September 23, 2021 23:50

openshift-ci Bot assigned rphillips Sep 27, 2021

kwoodson mentioned this pull request Sep 27, 2021

Enable Alibaba Cloud provider instances with expected ProviderID #2777

Merged

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2021

openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 27, 2021

sinnykumari approved these changes Sep 28, 2021

View reviewed changes

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2021

openshift-merge-robot merged commit d8a2040 into openshift:master Sep 29, 2021

Conversation

kwoodson commented Sep 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kwoodson commented Sep 22, 2021

Uh oh!

kwoodson commented Sep 22, 2021

Uh oh!

kwoodson commented Sep 22, 2021

Uh oh!

kikisdeliveryservice left a comment

Choose a reason for hiding this comment

Uh oh!

kikisdeliveryservice Sep 23, 2021

Choose a reason for hiding this comment

Uh oh!

kwoodson commented Sep 23, 2021

Uh oh!

sinnykumari commented Sep 27, 2021

Uh oh!

rphillips commented Sep 27, 2021

Uh oh!

rphillips commented Sep 27, 2021

Uh oh!

openshift-ci Bot commented Sep 28, 2021

Uh oh!

openshift-bot commented Sep 28, 2021

Uh oh!

openshift-bot commented Sep 28, 2021

Uh oh!

openshift-bot commented Sep 28, 2021

Uh oh!

openshift-bot commented Sep 28, 2021

Uh oh!

openshift-bot commented Sep 28, 2021

Uh oh!

openshift-bot commented Sep 28, 2021

Uh oh!

openshift-bot commented Sep 28, 2021

Uh oh!

openshift-bot commented Sep 28, 2021

Uh oh!

openshift-bot commented Sep 28, 2021

Uh oh!

openshift-bot commented Sep 28, 2021

Uh oh!

openshift-bot commented Sep 28, 2021

Uh oh!

openshift-bot commented Sep 28, 2021

Uh oh!

openshift-bot commented Sep 28, 2021

Uh oh!

openshift-bot commented Sep 28, 2021

Uh oh!

openshift-bot commented Sep 28, 2021

Uh oh!

openshift-bot commented Sep 28, 2021

Uh oh!

openshift-bot commented Sep 28, 2021

Uh oh!

openshift-bot commented Sep 28, 2021

Uh oh!

openshift-bot commented Sep 28, 2021

Uh oh!

openshift-bot commented Sep 28, 2021

Uh oh!

openshift-bot commented Sep 28, 2021

Uh oh!

openshift-bot commented Sep 28, 2021

Uh oh!

openshift-bot commented Sep 28, 2021

Uh oh!

openshift-bot commented Sep 28, 2021

Uh oh!

openshift-bot commented Sep 28, 2021

Uh oh!

openshift-bot commented Sep 28, 2021

Uh oh!

openshift-bot commented Sep 28, 2021

Uh oh!

kwoodson commented Sep 22, 2021 •

edited

Loading

openshift-ci Bot commented Sep 28, 2021 •

edited

Loading