Add PowerVS platform#2801
Conversation
|
/retest |
|
/assign @kikisdeliveryservice |
|
/lgtm |
|
I'll also add that we tested with these changes and were able to stand up a cluster in Power VS. |
Prashanth684
force-pushed
the
powervs-mco
branch
from
5085948 to
975c07c
Compare
openshift-ci
Bot
added
needs-rebase
Enable Power VS(Virtual Servers) as a platform. PowerVS is an extension of IBMCloud which supports deploying ppc64le VMs. Details here: openshift/enhancements#736 The hostname for the VMs are set through afterburn which reads the metadata provided through the config drive which is the primary mechanism through which ignition and hostname are provided. (coreos/afterburn#592) Cross referencing some other PRs for completeness: openshift/installer#5270 openshift/installer#5224 (closed, WIP to split into multiple PRs) ova images for PowerVS are already generated today: coreos/coreos-assembler#2200 coreos/coreos-assembler#2361
Prashanth684
force-pushed
the
powervs-mco
branch
from
975c07c to
ed4ea6a
Compare
openshift-ci
Bot
removed
the
needs-rebase
|
/retest-required |
1 similar comment
|
/retest-required |
|
/lgtm |
|
@kikisdeliveryservice is this good for an approval ? any concerns? |
| res: "", | ||
| }, { | ||
| platform: configv1.PowerVSPlatformType, | ||
| res: "", |
There was a problem hiding this comment.
Shouldn't this be "powervs"
There was a problem hiding this comment.
so , powervs is an external cloud provider -so it should actually be "external", but as of today there is no CCM implemented for PowerVS. the node controller is implemented as part of the cluster-api-provider which fills the gap until there is a CCM and then this will be "external". discussion here: openshift/enhancements#736 (comment)
There was a problem hiding this comment.
also in my previous commit i removed it from the cloudprovider function (which was returning powervs previously): #2801 (comment)
|
/test bootstrap-e2e |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clnperez, Prashanth684, sinnykumari The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
9 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@Prashanth684: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
15 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
8 participants
Enable Power VS(Virtual Servers) as a platform. PowerVS is an extension of IBMCloud which supports deploying ppc64le VMs.
Details here: openshift/enhancements#736
The hostname for the VMs are set through afterburn which reads the metadata provided through the config drive which is the primary mechanism through which ignition and hostname are provided.
(coreos/afterburn#592)
Cross referencing some other PRs for completeness:
openshift/installer#5270
openshift/installer#5224 (closed, WIP to split into multiple PRs)
ova images for PowerVS are already generated today:
coreos/coreos-assembler#2200
coreos/coreos-assembler#2361