Bug 2023657: Only write ssh keys if core user exists by mkenigs · Pull Request #2834 · openshift/machine-config-operator

mkenigs · 2021-11-18T23:12:14Z

Ignore ssh keys if core user does not exist, rather than failing and
degrading the node. Degrading is undesirable because ssh keys were
previously written as root, so machine configs with ssh keys could be
applied even if the core user did not exist

openshift-ci · 2021-11-18T23:12:19Z

@mkenigs: This pull request references Bugzilla bug 2023657, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2023657: Only write ssh keys if core user exists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mkenigs · 2021-11-18T23:17:58Z

/bugzilla refresh

openshift-ci · 2021-11-18T23:18:06Z

@mkenigs: This pull request references Bugzilla bug 2023657, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (rioliu@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sinnykumari · 2021-11-22T10:18:00Z

Umm, looking at the bug I think ssh key update will still fail on RHEL node and this could be problematic and most likely come back to us as upgrade blocker. There are chances that in a cluster there are RHCOS+RHEL node in same pool and MCO will be stuck in updating because of failure on RHEL node. Is the PR intended to log that updating ssh key is not supported when core user doesn't exist and still fail?

mkenigs · 2021-11-22T14:53:18Z

Yikes that feels bad, I forgot a very important return statement 🤦 Fixed. Never completely resolved the discussion on the Bugzilla, but now is this desired behavior?

openshift-ci · 2021-11-22T18:05:55Z

@mkenigs: This pull request references Bugzilla bug 2023657, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2023657: Only write ssh keys if core user exists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mkenigs · 2021-11-22T18:12:39Z

/bugzilla refresh

openshift-ci · 2021-11-22T18:12:44Z

@mkenigs: This pull request references Bugzilla bug 2023657, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (rioliu@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yuqi-zhang

I think this is a good middle ground. This also means that if an admin happened to create a core user on RHEL, it would share sshkeys, right?

mkenigs · 2021-11-22T22:49:44Z

Yeah it doesn't check RHCOS vs RHEL, it just checks whether core exists, so if core happens to exist on a RHEL node it should still write the key

sinnykumari · 2021-11-24T14:43:48Z

I too agree with this middle ground, hopefully someone doesn't come back to us complaining about it but if it happens we will at least how exactly they use it without having user core.
/lgtm

openshift-bot · 2021-11-24T15:08:17Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-24T15:34:23Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-24T16:00:32Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

cheesesashimi · 2021-11-29T22:57:42Z

/lgtm

This looks great!

openshift-ci · 2021-11-29T22:58:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheesesashimi, sinnykumari, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sinnykumari,yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-11-29T23:53:17Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T00:05:20Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T00:43:18Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T00:55:21Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T01:07:17Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T02:09:18Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T02:22:19Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T02:34:18Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T02:58:18Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T03:48:40Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T04:01:39Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T04:14:40Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T05:07:25Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T05:19:41Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T06:11:41Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T06:37:41Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T07:16:40Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T07:30:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-11-30T08:25:35Z

@mkenigs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-upgrade	`6092048`	link	false	`/test e2e-vsphere-upgrade`
ci/prow/e2e-aws-workers-rhel8	`6092048`	link	false	`/test e2e-aws-workers-rhel8`
ci/prow/e2e-aws-workers-rhel7	`6092048`	link	false	`/test e2e-aws-workers-rhel7`
ci/prow/e2e-aws-upgrade-single-node	`6092048`	link	false	`/test e2e-aws-upgrade-single-node`
ci/prow/okd-e2e-aws	`6092048`	link	false	`/test okd-e2e-aws`
ci/prow/e2e-aws-single-node	`6092048`	link	false	`/test e2e-aws-single-node`
ci/prow/e2e-aws-disruptive	`6092048`	link	false	`/test e2e-aws-disruptive`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-11-30T08:34:43Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T08:47:39Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T09:00:45Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T09:26:45Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-11-30T09:52:26Z

@mkenigs: All pull requests linked via external trackers have merged:

openshift/machine-config-operator#2834

Bugzilla bug 2023657 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2023657: Only write ssh keys if core user exists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci Bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 18, 2021

openshift-ci Bot requested review from kikisdeliveryservice and yuqi-zhang November 18, 2021 23:12

openshift-ci Bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 18, 2021

mkenigs force-pushed the 2023657 branch from 85e2c1d to 6f4f7ac Compare November 22, 2021 14:52

openshift-ci Bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 22, 2021

openshift-ci Bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 22, 2021

yuqi-zhang approved these changes Nov 22, 2021

View reviewed changes

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2021

openshift-ci Bot assigned sinnykumari Nov 24, 2021

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2021

openshift-ci Bot assigned cheesesashimi Nov 29, 2021

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2021

openshift-merge-robot merged commit 4607cba into openshift:master Nov 30, 2021

mkenigs deleted the 2023657 branch March 18, 2022 13:49

Conversation

mkenigs commented Nov 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Nov 18, 2021

Uh oh!

mkenigs commented Nov 18, 2021

Uh oh!

openshift-ci Bot commented Nov 18, 2021

Uh oh!

sinnykumari commented Nov 22, 2021

Uh oh!

mkenigs commented Nov 22, 2021

Uh oh!

openshift-ci Bot commented Nov 22, 2021

Uh oh!

mkenigs commented Nov 22, 2021

Uh oh!

openshift-ci Bot commented Nov 22, 2021

Uh oh!

yuqi-zhang left a comment

Choose a reason for hiding this comment

Uh oh!

mkenigs commented Nov 22, 2021

Uh oh!

sinnykumari commented Nov 24, 2021

Uh oh!

openshift-bot commented Nov 24, 2021

Uh oh!

openshift-bot commented Nov 24, 2021

Uh oh!

openshift-bot commented Nov 24, 2021

Uh oh!

cheesesashimi commented Nov 29, 2021

Uh oh!

openshift-ci Bot commented Nov 29, 2021

Uh oh!

openshift-bot commented Nov 29, 2021

Uh oh!

openshift-bot commented Nov 30, 2021

Uh oh!

openshift-bot commented Nov 30, 2021

Uh oh!

openshift-bot commented Nov 30, 2021

Uh oh!

openshift-bot commented Nov 30, 2021

Uh oh!

openshift-bot commented Nov 30, 2021

Uh oh!

openshift-bot commented Nov 30, 2021

Uh oh!

openshift-bot commented Nov 30, 2021

Uh oh!

openshift-bot commented Nov 30, 2021

Uh oh!

openshift-bot commented Nov 30, 2021

Uh oh!

openshift-bot commented Nov 30, 2021

Uh oh!

openshift-bot commented Nov 30, 2021

Uh oh!

openshift-bot commented Nov 30, 2021

Uh oh!

openshift-bot commented Nov 30, 2021

Uh oh!

openshift-bot commented Nov 30, 2021

Uh oh!

openshift-bot commented Nov 30, 2021

Uh oh!

openshift-bot commented Nov 30, 2021

Uh oh!

openshift-bot commented Nov 30, 2021

Uh oh!

openshift-ci Bot commented Nov 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Nov 30, 2021

Uh oh!

openshift-bot commented Nov 30, 2021

Uh oh!

mkenigs commented Nov 18, 2021 •

edited

Loading

openshift-ci Bot commented Nov 30, 2021 •

edited

Loading