Skip to content

owners: add reviewers for MCO repo#2850

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
sinnykumari:owners
Dec 2, 2021
Merged

owners: add reviewers for MCO repo#2850
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
sinnykumari:owners

Conversation

@sinnykumari
Copy link
Copy Markdown
Contributor

@sinnykumari sinnykumari commented Dec 1, 2021

Includes existing approvers and new members in MCO team

@sinnykumari
owners: add reviewers for MCO repo
f503730 
Includes existing approvers and new members in MCO team
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2021
yuqi-zhang
yuqi-zhang approved these changes Dec 1, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

kikisdeliveryservice commented Dec 2, 2021

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, sinnykumari, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice,sinnykumari,yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 2, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

13 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 2, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 2, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 2, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 2, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 2, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 2, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 2, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 2, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 2, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 2, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 2, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 2, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 2, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 2, 2021 •
edited
Loading

@sinnykumari: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-upgrade-single-node f503730 link false /test e2e-aws-upgrade-single-node
ci/prow/okd-e2e-aws f503730 link false /test okd-e2e-aws
ci/prow/e2e-aws-workers-rhel7 f503730 link false /test e2e-aws-workers-rhel7
ci/prow/e2e-aws-disruptive f503730 link false /test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sinnykumari
Copy link
Copy Markdown
Contributor Author

sinnykumari commented Dec 2, 2021

/skip

Change in owner file shouldn't have any impact on upgrade test(which is usually flaky now days). Overriding to save some CI resources.
/override e2e-agnostic-upgrade

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 2, 2021

@sinnykumari: /override requires a failed status context or a job name to operate on.
The following unknown contexts were given:

  • e2e-agnostic-upgrade

Only the following contexts were expected:

  • ci/prow/bootstrap-unit
  • ci/prow/e2e-agnostic-upgrade
  • ci/prow/e2e-aws
  • ci/prow/e2e-aws-disruptive
  • ci/prow/e2e-aws-serial
  • ci/prow/e2e-aws-single-node
  • ci/prow/e2e-aws-upgrade-single-node
  • ci/prow/e2e-aws-workers-rhel7
  • ci/prow/e2e-aws-workers-rhel8
  • ci/prow/e2e-gcp-op
  • ci/prow/e2e-gcp-op-single-node
  • ci/prow/e2e-metal-ipi
  • ci/prow/e2e-ovn-step-registry
  • ci/prow/e2e-vsphere-upgrade
  • ci/prow/images
  • ci/prow/okd-e2e-aws
  • ci/prow/okd-images
  • ci/prow/unit
  • ci/prow/verify
  • pull-ci-openshift-machine-config-operator-release-4.1-e2e-aws
  • pull-ci-openshift-machine-config-operator-release-4.1-e2e-aws-disruptive
  • pull-ci-openshift-machine-config-operator-release-4.1-images
  • pull-ci-openshift-machine-config-operator-release-4.1-unit
  • pull-ci-openshift-machine-config-operator-release-4.1-verify
  • pull-ci-openshift-machine-config-operator-release-4.10-bootstrap-unit
  • pull-ci-openshift-machine-config-operator-release-4.10-e2e-agnostic-upgrade
  • pull-ci-openshift-machine-config-operator-release-4.10-e2e-aws-serial
  • pull-ci-openshift-machine-config-operator-release-4.10-e2e-aws-single-node
  • pull-ci-openshift-machine-config-operator-release-4.10-e2e-aws-upgrade-single-node
  • pull-ci-openshift-machine-config-operator-release-4.10-e2e-aws-workers-rhel7
  • pull-ci-openshift-machine-config-operator-release-4.10-e2e-aws-workers-rhel8
  • pull-ci-openshift-machine-config-operator-release-4.10-e2e-gcp-op
  • pull-ci-openshift-machine-config-operator-release-4.10-e2e-gcp-op-single-node
  • pull-ci-openshift-machine-config-operator-release-4.10-e2e-metal-ipi
  • pull-ci-openshift-machine-config-operator-release-4.10-e2e-ovn-step-registry
  • pull-ci-openshift-machine-config-operator-release-4.10-e2e-vsphere-upgrade
  • pull-ci-openshift-machine-config-operator-release-4.10-okd-e2e-aws
  • pull-ci-openshift-machine-config-operator-release-4.10-okd-images
  • tide
Details

In response to this:

/skip

Change in owner file shouldn't have any impact on upgrade test(which is usually flaky now days). Overriding to save some CI resources.
/override e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sinnykumari
Copy link
Copy Markdown
Contributor Author

sinnykumari commented Dec 2, 2021

/override ci/prow/e2e-agnostic-upgrade

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 2, 2021

@sinnykumari: Overrode contexts on behalf of sinnykumari: ci/prow/e2e-agnostic-upgrade

Details

In response to this:

/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 29f2861 into openshift:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

Assignees

@kikisdeliveryservice kikisdeliveryservice

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sinnykumari @kikisdeliveryservice @openshift-bot @yuqi-zhang @openshift-merge-robot