[release-4.9] Bug 2058511: Prepend to search domains instead of replacing#2965
Conversation
Previously the resolv-prepender script overwrote the search domains with a specific set of domains, notably including the cluster domain so cluster addresses will resolve. However, this is not desirable as it may miss some configured search domains if they don't happen to come in via DHCP (for example, search domains configured on an interface via nmcli/nmstate). This change modifies the prepender logic to also prepend the cluster domain to the search domain list rather than overwrite it completely. This means that we don't have to manage the full list of search domains like we did before. We just add on to the default ones NetworkManager writes, which should result in less confusing DNS behavior from the script. One caveat is that I don't know if the same method can be used for the resolved case and I don't have any way to test that locally, so I've left the logic there alone for now. If this turns out to be a problem for OKD as well then someone will have to work with us to get that behavior changed too.
|
@openshift-cherrypick-robot: Bugzilla bug 2017564 has been cloned as Bugzilla bug 2058511. Retitling PR to link against new bug. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
Bot
changed the title
openshift-ci
Bot
added
the
bugzilla/severity-urgent
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 2058511, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
Bot
added
the
bugzilla/valid-bug
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
|
@creydr: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 2058511. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
4 participants
This is an automated cherry-pick of #2823
/assign creydr