Skip to content

Add new extension for kerberos#2979

Merged
openshift-ci[bot] merged 1 commit intoopenshift:masterfrom
mike-nguyen:kerberos_extensions
Mar 3, 2022
Merged

Add new extension for kerberos#2979
openshift-ci[bot] merged 1 commit intoopenshift:masterfrom
mike-nguyen:kerberos_extensions

Conversation

@mike-nguyen
Copy link
Copy Markdown
Member

@mike-nguyen mike-nguyen commented Mar 2, 2022

- What I did
Added support for new RHCOS extension called kerberos. See openshift/os#731. It will allow users to kerberize their NFS mounts.

- How to verify it
Create a MachineConfig with kerberos extension as described in https://github.com/openshift/machine-config-operator/blob/master/docs/MachineConfiguration.md#rhcos-extensions and apply it to a cluster either day 0 or day 1.

- Description for the changelog
Add support for a new RHCOS extension called "kerberos".

@openshift-ci openshift-ci Bot requested review from cgwalters and yuqi-zhang March 2, 2022 15:53
@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

kikisdeliveryservice commented Mar 2, 2022

This adds support for a new RHCOS extension called "kerberos".

It will allow users to kerberize their NFS mounts.
@mike-nguyen mike-nguyen force-pushed the kerberos_extensions branch from a5054f1 to a5bb45c Compare March 2, 2022 17:45
@mike-nguyen
Copy link
Copy Markdown
Member Author

mike-nguyen commented Mar 2, 2022

Can you also update: https://github.com/openshift/machine-config-operator/blob/4c1004761063952af76ee5a5a8454c4e5dab7128/docs/MachineConfiguration.md#rhcos-extensions and

I see the kernel-devel extension is also in the test but don't know when the support was added. I updated the kerberos part.

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

Can you also update: https://github.com/openshift/machine-config-operator/blob/4c1004761063952af76ee5a5a8454c4e5dab7128/docs/MachineConfiguration.md#rhcos-extensions and

I see the kernel-devel extension is also in the test but don't know when the support was added. I updated the kerberos part.

For ref that is intentional 😄 662f13b

Copy link
Copy Markdown
Contributor

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Mike!

Might also want to get this into official ocp docs?

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

for final review
/assign @cgwalters

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2022
@mike-nguyen
Copy link
Copy Markdown
Member Author

mike-nguyen commented Mar 2, 2022

Great job Mike!

Might also want to get this into official ocp docs?

Thanks! Docs have been requested in the epic.

@cgwalters
Copy link
Copy Markdown
Member

Nice work!

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, kikisdeliveryservice, mike-nguyen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [cgwalters,kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

14 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 3, 2022

@mike-nguyen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-upgrade-single-node a5bb45c link false /test e2e-aws-upgrade-single-node
ci/prow/e2e-aws-single-node a5bb45c link false /test e2e-aws-single-node
ci/prow/e2e-vsphere-upgrade a5bb45c link false /test e2e-vsphere-upgrade
ci/prow/e2e-aws-disruptive a5bb45c link false /test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci Bot merged commit 6115967 into openshift:master Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants