Remove bindata.go#2983
Conversation
This has been dead code since openshift@d08090d I was briefly confused by this when trying to figure out a different bug around why my change to add a new field to controllerconfig wasn't working.
openshift-ci
Bot
added
the
approved
kikisdeliveryservice
left a comment
kikisdeliveryservice
left a comment
There was a problem hiding this comment.
Ahh I see what happened. That PR merged but there was another longer lived PR that modified the file that merged a few days after which readded the removed file in its entirety.
Nice catch!! Thanks Colin.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, kikisdeliveryservice The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@cgwalters: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
4 participants
This has been dead code since d08090d
I was briefly confused by this when trying to figure out a different
bug around why my change to add a new field to controllerconfig
wasn't working.