Bug 2055433: configure-ovs: set networking on before restarting NetworkManager by jcaamano · Pull Request #3006 · openshift/machine-config-operator

jcaamano · 2022-03-10T13:21:15Z

nm-online -s does not wait for autoconnect profiles to be active if
NM is restarted with networking off. The fact that it does most of the
time is just a race condition.

Set networking on before restarting NetworkManager.

Additionally, try not to re-activate connections more than necessary.

Signed-off-by: Jaime Caamaño Ruiz jcaamano@redhat.com

- What I did

- How to verify it

- Description for the changelog

openshift-ci · 2022-03-10T13:21:53Z

@jcaamano: This pull request references Bugzilla bug 2055433, which is invalid:

expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[WIP] Bug 2055433: configure-ovs: wait for autoconnect profiles to be active

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kikisdeliveryservice · 2022-03-10T18:47:52Z

/assign @trozet

openshift-ci · 2022-03-10T19:39:25Z

@jcaamano: This pull request references Bugzilla bug 2055433, which is invalid:

expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[WIP] Bug 2055433: configure-ovs: wait for autoconnect profiles to be active

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-03-10T19:56:27Z

@jcaamano: This pull request references Bugzilla bug 2055433, which is invalid:

expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[WIP] Bug 2055433: configure-ovs: set networking on before restarting NetworkManager

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-03-11T09:57:08Z

@jcaamano: This pull request references Bugzilla bug 2055433, which is invalid:

expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[WIP] Bug 2055433: configure-ovs: set networking on before restarting NetworkManager

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jcaamano · 2022-03-16T12:46:49Z

/retest-required
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-ipv6

trozet

/lgtm

openshift-bot · 2022-03-23T01:01:06Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-03-23T01:02:10Z

@openshift-bot: An error was encountered querying GitHub for users with public email (anusaxen@redhat.com) for bug 2055433 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: connect: no route to host

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-03-24T01:00:57Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-03-24T01:01:02Z

@openshift-bot: This pull request references Bugzilla bug 2055433, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.11.0) matches configured target release for branch (4.11.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jcaamano · 2022-03-25T18:35:21Z

Fixed some problems handling filenames with spaces.

Had the loop of configure ovnk, migrate to second nic and revert to sdn running for hours. I guess this proofs nothing, but at least I did it :P

trozet

/lgtm

openshift-ci · 2022-03-29T13:34:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jcaamano, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [cgwalters]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2022-03-29T14:22:27Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-29T15:14:30Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-29T16:19:27Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-29T20:39:29Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-29T23:53:55Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-30T02:03:55Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-30T14:15:51Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-30T14:51:48Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-30T21:58:49Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-31T05:07:58Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-31T06:00:23Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-31T12:52:29Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-31T13:05:27Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-31T16:46:28Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-31T18:04:27Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-31T18:30:28Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-03-31T19:39:16Z

@jcaamano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-single-node	7ec45d0c1aa6155c0407d6844f327e7e04f1c769	link	false	`/test e2e-aws-single-node`
ci/prow/e2e-vsphere-upgrade	7ec45d0c1aa6155c0407d6844f327e7e04f1c769	link	false	`/test e2e-vsphere-upgrade`
ci/prow/e2e-aws-disruptive	7ec45d0c1aa6155c0407d6844f327e7e04f1c769	link	false	`/test e2e-aws-disruptive`
ci/prow/e2e-aws-upgrade-single-node	7ec45d0c1aa6155c0407d6844f327e7e04f1c769	link	false	`/test e2e-aws-upgrade-single-node`
ci/prow/e2e-metal-ipi	7ec45d0c1aa6155c0407d6844f327e7e04f1c769	link	false	`/test e2e-metal-ipi`
ci/prow/e2e-aws-workers-rhel8	7ec45d0c1aa6155c0407d6844f327e7e04f1c769	link	false	`/test e2e-aws-workers-rhel8`
ci/prow/e2e-aws-serial	7ec45d0c1aa6155c0407d6844f327e7e04f1c769	link	false	`/test e2e-aws-serial`
ci/prow/e2e-gcp-op-single-node	7ec45d0c1aa6155c0407d6844f327e7e04f1c769	link	false	`/test e2e-gcp-op-single-node`
ci/prow/e2e-metal-ipi-ovn-dualstack	56409ad1bb401ee314d39c018675fbea985e5a2a	link	false	`/test e2e-metal-ipi-ovn-dualstack`
ci/prow/e2e-metal-ipi-ovn-ipv6	56409ad1bb401ee314d39c018675fbea985e5a2a	link	false	`/test e2e-metal-ipi-ovn-ipv6`
ci/prow/e2e-ovn-step-registry	56409ad1bb401ee314d39c018675fbea985e5a2a	link	false	`/test e2e-ovn-step-registry`
ci/prow/4.12-upgrade-from-stable-4.11-images	56409ad1bb401ee314d39c018675fbea985e5a2a	link	true	`/test 4.12-upgrade-from-stable-4.11-images`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2022-03-31T20:40:28Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-31T21:58:28Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-03-31T22:51:59Z

@jcaamano: All pull requests linked via external trackers have merged:

openshift/machine-config-operator#3006

Bugzilla bug 2055433 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2055433: configure-ovs: set networking on before restarting NetworkManager

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jcaamano · 2022-04-04T09:03:46Z

/cherry-pick release-4.10

openshift-cherrypick-robot · 2022-04-04T09:04:29Z

@jcaamano: new pull request created: #3056

Details

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jcaamano changed the title ~~configure-ovs: wait for autoconnect profiles to be active~~ [WIP] Bug 2055433: configure-ovs: wait for autoconnect profiles to be active Mar 10, 2022

openshift-ci Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. labels Mar 10, 2022

openshift-ci Bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 10, 2022

openshift-ci Bot requested review from kikisdeliveryservice and yuqi-zhang March 10, 2022 13:22

jcaamano force-pushed the master branch from ed288fd to 28ae2f2 Compare March 10, 2022 15:58

openshift-ci Bot assigned trozet Mar 10, 2022

jcaamano changed the title ~~[WIP] Bug 2055433: configure-ovs: wait for autoconnect profiles to be active~~ [WIP] Bug 2055433: configure-ovs: set networking on before restarting NetworkManager Mar 10, 2022

jcaamano force-pushed the master branch 2 times, most recently from a4299b2 to ab96764 Compare March 10, 2022 19:55

jcaamano force-pushed the master branch from ab96764 to 3d294b6 Compare March 11, 2022 09:47

jcaamano force-pushed the master branch 2 times, most recently from ed5911e to 7ec45d0 Compare March 14, 2022 09:31

jcaamano changed the title ~~[WIP] Bug 2055433: configure-ovs: set networking on before restarting NetworkManager~~ Bug 2055433: configure-ovs: set networking on before restarting NetworkManager Mar 15, 2022

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2022

cgwalters mentioned this pull request Mar 15, 2022

machine-config-operator: Drop skip_if_only_changed for all optional: true jobs openshift/release#27015

Merged

trozet approved these changes Mar 22, 2022

View reviewed changes

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2022

openshift-ci Bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 24, 2022

jcaamano force-pushed the master branch from 56409ad to ebf1072 Compare March 25, 2022 18:32

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2022

trozet approved these changes Mar 29, 2022

View reviewed changes

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2022

openshift-merge-robot merged commit abceabc into openshift:master Mar 31, 2022

openshift-cherrypick-robot mentioned this pull request Apr 4, 2022

[release-4.10] Bug 2071574: configure-ovs: set networking on before restarting NetworkManager #3056

Closed

Conversation

jcaamano commented Mar 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Mar 10, 2022

Uh oh!

kikisdeliveryservice commented Mar 10, 2022

Uh oh!

openshift-ci Bot commented Mar 10, 2022

Uh oh!

openshift-ci Bot commented Mar 10, 2022

Uh oh!

openshift-ci Bot commented Mar 11, 2022

Uh oh!

jcaamano commented Mar 16, 2022

Uh oh!

trozet left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-bot commented Mar 23, 2022

Uh oh!

openshift-ci Bot commented Mar 23, 2022

Uh oh!

openshift-bot commented Mar 24, 2022

Uh oh!

openshift-ci Bot commented Mar 24, 2022

Uh oh!

jcaamano commented Mar 25, 2022

Uh oh!

trozet left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Mar 29, 2022

Uh oh!

openshift-bot commented Mar 29, 2022

Uh oh!

openshift-bot commented Mar 29, 2022

Uh oh!

openshift-bot commented Mar 29, 2022

Uh oh!

openshift-bot commented Mar 29, 2022

Uh oh!

openshift-bot commented Mar 29, 2022

Uh oh!

openshift-bot commented Mar 30, 2022

Uh oh!

openshift-bot commented Mar 30, 2022

Uh oh!

openshift-bot commented Mar 30, 2022

Uh oh!

openshift-bot commented Mar 30, 2022

Uh oh!

openshift-bot commented Mar 31, 2022

Uh oh!

openshift-bot commented Mar 31, 2022

Uh oh!

openshift-bot commented Mar 31, 2022

Uh oh!

openshift-bot commented Mar 31, 2022

Uh oh!

openshift-bot commented Mar 31, 2022

Uh oh!

openshift-bot commented Mar 31, 2022

Uh oh!

openshift-bot commented Mar 31, 2022

Uh oh!

openshift-ci Bot commented Mar 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Mar 31, 2022

Uh oh!

openshift-bot commented Mar 31, 2022

Uh oh!

openshift-ci Bot commented Mar 31, 2022

Uh oh!

jcaamano commented Apr 4, 2022

Uh oh!

openshift-cherrypick-robot commented Apr 4, 2022

Uh oh!

Reviewers

jcaamano commented Mar 10, 2022 •

edited

Loading

openshift-ci Bot commented Mar 31, 2022 •

edited

Loading