server/api_test: Adjust expected error message for Go 1.18#3019
server/api_test: Adjust expected error message for Go 1.18#3019openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
Right now Fedora doesn't ship Go 1.17, only Go 1.18beta. That version emits a different error message for incompatible TLS versions. Adjust our unit test to handle both. (Also, a motivation for me is to cross-check the new CI configuration after openshift/release#27015 )
|
Yep, openshift/release#27015 seemed to have the intended effect! Now we're only launching 3 clusters¹ instead of 10. ¹ (for this PR that only affects the unit test and can't ever break anything in-cluster, but that's an aside) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, kikisdeliveryservice The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
11 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
hmm: |
|
This PR specifically hit that error 2x 🤔 |
|
Hmm. Thanks for highlighting that! It's not related to this PR, but I think it is a bug in rpm-ostree. Investigating. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
OK, this cannot break the e2e tests, it only affects the unit tests. Retesting our e2es is just a waste of money. |
|
@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/e2e-gcp-op DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@cgwalters: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Right now Fedora doesn't ship Go 1.17, only Go 1.18beta. That
version emits a different error message for incompatible TLS
versions. Adjust our unit test to handle both.
(Also, a motivation for me is to cross-check the new CI configuration
after openshift/release#27015 )