Skip to content

server/api_test: Adjust expected error message for Go 1.18#3019

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
cgwalters:go118-api-unit
Mar 16, 2022
Merged

server/api_test: Adjust expected error message for Go 1.18#3019
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
cgwalters:go118-api-unit

Conversation

@cgwalters
Copy link
Copy Markdown
Member

Right now Fedora doesn't ship Go 1.17, only Go 1.18beta. That
version emits a different error message for incompatible TLS
versions. Adjust our unit test to handle both.

(Also, a motivation for me is to cross-check the new CI configuration
after openshift/release#27015 )

Right now Fedora doesn't ship Go 1.17, only Go 1.18beta.  That
version emits a different error message for incompatible TLS
versions.  Adjust our unit test to handle both.

(Also, a motivation for me is to cross-check the new CI configuration
 after openshift/release#27015 )
@openshift-ci openshift-ci Bot requested review from jkyros and yuqi-zhang March 15, 2022 21:57
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2022
@cgwalters
Copy link
Copy Markdown
Member Author

Yep, openshift/release#27015 seemed to have the intended effect! Now we're only launching 3 clusters¹ instead of 10.

¹ (for this PR that only affects the unit test and can't ever break anything in-cluster, but that's an aside)

Copy link
Copy Markdown
Contributor

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, kikisdeliveryservice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [cgwalters,kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

11 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

hmm:

    helpers.go:262: Setup complete (took 2m58.552950553s)
Job for rpm-ostreed.service failed.
See "systemctl status rpm-ostreed.service" and "journalctl -xe" for details.
error: exit status: 1
command terminated with exit code 1
    utils.go:356: 
        	Error Trace:	utils.go:356
        	            				helpers.go:37
        	            				helpers.go:27
        	            				mcd_config_drift.go:170
        	            				shared.go:45
        	Error:      	Expected nil, but got: &exec.ExitError{ProcessState:(*os.ProcessState)(0xc00000e6d8), Stderr:[]uint8(nil)}
        	Test:       	TestRunShared/MCD_Config_Drift
        	Messages:   	failed to exec cmd [chroot /rootfs /usr/bin/rpm-ostree kargs] on node ci-op-l9f2cpj3-1354f-gps7k-worker-a-m7x5l: ● rpm-ostreed.service - rpm-ostree System Management Daemon 

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

This PR specifically hit that error 2x 🤔

@cgwalters
Copy link
Copy Markdown
Member Author

Hmm. Thanks for highlighting that! It's not related to this PR, but I think it is a bug in rpm-ostree. Investigating.

@cgwalters
Copy link
Copy Markdown
Member Author

coreos/rpm-ostree#3523

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@cgwalters
Copy link
Copy Markdown
Member Author

OK, this cannot break the e2e tests, it only affects the unit tests. Retesting our e2es is just a waste of money.
/override ci/prow/e2e-gcp-op

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 16, 2022

@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/e2e-gcp-op

Details

In response to this:

OK, this cannot break the e2e tests, it only affects the unit tests. Retesting our e2es is just a waste of money.
/override ci/prow/e2e-gcp-op

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit d4b1a8c into openshift:master Mar 16, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 16, 2022

@cgwalters: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants