e2e: Use /proc/cmdline instead of rpm-ostree kargs#3034
e2e: Use /proc/cmdline instead of rpm-ostree kargs#3034openshift-merge-robot merged 1 commit intoopenshift:masterfrom
/proc/cmdline instead of rpm-ostree kargs#3034Conversation
The main motivation here is to work around coreos/rpm-ostree#3523 (Which is itself a workaround for a RHEL8 systemd bug) Basically this e2e is invoking `rpm-ostree kargs` in a pretty tight loop which triggers that bug. To read the kernel command line, we can just read `/proc/cmdline` instead. (Now, this is the *actual* cmdline instead of just rpm-ostree's view of it, but it should be fine)
|
(not tested, but e2e will do that) |
|
|
|
/test e2e-gcp-op |
|
/override ci/prow/e2e-aws |
|
For ref we do exactly this in the actual kargs test: machine-config-operator/test/e2e/mcd_test.go Line 148 in 6115967 /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, kikisdeliveryservice The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/e2e-aws |
|
@kikisdeliveryservice: Overrode contexts on behalf of kikisdeliveryservice: ci/prow/e2e-agnostic-upgrade, ci/prow/e2e-aws DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@cgwalters: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The main motivation here is to work around
coreos/rpm-ostree#3523
(Which is itself a workaround for a RHEL8 systemd bug)
Basically this e2e is invoking
rpm-ostree kargsin a prettytight loop which triggers that bug.
To read the kernel command line, we can just read
/proc/cmdlineinstead. (Now, this is the actual cmdline instead of just rpm-ostree's
view of it, but it should be fine)