e2e/kdump_test: Add kdump e2e test using mco#3186
e2e/kdump_test: Add kdump e2e test using mco#3186gursewak1997 wants to merge 1 commit intoopenshift:masterfrom
Conversation
Add e2e test for OCP CI that validates enabling kdump and generating kernel core via machine config successfully
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gursewak1997 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| } | ||
| t.Logf("Node %s has expected craskkernel karg", infraNode.Name) | ||
|
|
||
| helpers.ExecCmdOnNode(t, cs, infraNode, "/bin/sh", "-c", string("chroot /rootfs systemctl reboot")) |
There was a problem hiding this comment.
why are we manually doing node reboot instead of using a MachineConfig? Is this how user is supposed to be enabling kdump?
There was a problem hiding this comment.
|
|
||
| helpers.ExecCmdOnNode(t, cs, infraNode, "/bin/sh", "-c", string("chroot /rootfs systemctl reboot")) | ||
| // Waiting for the node to come back up after reboot | ||
| time.Sleep(time.Minute) |
There was a problem hiding this comment.
This is not the reliable way to know that node is up and accessible via cluster. Would be good to check for node annotation for Ready state.
|
@gursewak1997 Can you link to something that explains what kdump is? |
Sure, this is the latest kdump doc: https://docs.openshift.com/container-platform/4.10/support/troubleshooting/troubleshooting-operating-system-issues.html |
|
So we debated places for testing over here recently: openshift/os#746 This one in particular is something that's quite unlikely to be broken by any changes to the MCO. The bits of the MCO that are involved here boils down to passing kernel arguments, which is already covered by other tests. The thing most likely to break kdump is changes to RHCOS...but we already have a test for that right? |
True, we do have kernel args test already in this repo and we do test kdump wrt changes in RHCOS in fedora-coreos-config. So overall, it should be good. |
Seems to me then we don't need to add this in our e2e test, right? If kdump is not going to break with MCO PRs and doesn't add additional value, it would be ideal to not add this test as it will use ci resources un-necessary. |
|
We have decided that this is not strictly required to get kdump out of Tech Preview (https://issues.redhat.com/browse/COS-158). I think that testing kdump support in the MCO will make sense once we have direct support for it in MachineConfigs: https://issues.redhat.com/browse/MCO-42 |
kikisdeliveryservice
added
the
do-not-merge/hold
|
To reiterate, I think we should push for having more OS tests in openshift/origin: openshift/os#746 (comment) In fact, we could probably take some of the MCO tests here and put them in origin...for example One thing related to this is that openshift/origin already has code which does machineset scaling tests; and we could use that to transiently spin up a new worker node for some of this OS-targeted testing. |
|
openshift/origin@dc64c6f is another example of a test case there |
+1
Nice, MCO could definitely make use of these tests for Day1 workflow. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
Bot
added
the
lifecycle/stale
|
@gursewak1997: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
Bot
added
lifecycle/rotten
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
Add e2e test for OCP CI that validates enabling kdump and generating kernel core via machine config successfully. This is also one of the step to take kdump feature out of tech preview.
- What I did
Added e2e test to test kdump feature
- How to verify it
Run the e2e test locally or verify it on CI job.
- Description for the changelog
Add e2e test for kdump