Skip to content

[release-4.8] Bug 2108699: storage.conf: remove obsolete option override_kernel_check#3259

Merged
openshift-ci[bot] merged 1 commit intoopenshift:release-4.8from
openshift-cherrypick-robot:cherry-pick-2845-to-release-4.8
Aug 3, 2022
Merged

[release-4.8] Bug 2108699: storage.conf: remove obsolete option override_kernel_check#3259
openshift-ci[bot] merged 1 commit intoopenshift:release-4.8from
openshift-cherrypick-robot:cherry-pick-2845-to-release-4.8

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #2845

/assign QiWang19

The storage.conf(5) override_kernel_check option was removed from the
containers/storage library in early 2019:

  containers/storage@bd6cac9

With recent version of CRI-O present in OCP >= 4.9, the presence of
this field causes sandbox creation failure when using user namespaces:

  Warning  FailedCreatePodSandBox  SSs (xN over MMm)  kubelet
  (combined from similar events): Failed to create pod sandbox: rpc
  error: code = Unknown desc = error creating pod sandbox with name
  "{NAME}": error creating an ID-mapped copy of layer "{HASH}":
  time="{TIMESTAMP}" level=warning msg="Failed to decode the keys
  [\"storage.options.override_kernel_check\"] from
  \"/etc/containers/storage.conf\"."

Remove the override_kernel_check option.

Signed-off-by: Fraser Tweedale <ftweedal@redhat.com>
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 21, 2022

@openshift-cherrypick-robot: Bugzilla bug 2027927 has been cloned as Bugzilla bug 2109599. Retitling PR to link against new bug.
/retitle [release-4.8] Bug 2109599: storage.conf: remove obsolete option override_kernel_check

Details

In response to this:

[release-4.8] Bug 2027927: storage.conf: remove obsolete option override_kernel_check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot changed the title [release-4.8] Bug 2027927: storage.conf: remove obsolete option override_kernel_check [release-4.8] Bug 2109599: storage.conf: remove obsolete option override_kernel_check Jul 21, 2022
@openshift-ci openshift-ci Bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 21, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 21, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2109599, which is invalid:

  • expected dependent Bugzilla bug 2027927 to target a release in 4.9.0, 4.9.z, but it targets "4.10.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.8] Bug 2109599: storage.conf: remove obsolete option override_kernel_check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from sinnykumari and yuqi-zhang July 21, 2022 15:16
@QiWang19
Copy link
Copy Markdown
Member

/retitle [release-4.8] Bug 2108699: storage.conf: remove obsolete option override_kernel_check

@openshift-ci openshift-ci Bot changed the title [release-4.8] Bug 2109599: storage.conf: remove obsolete option override_kernel_check [release-4.8] Bug 2108699: storage.conf: remove obsolete option override_kernel_check Jul 21, 2022
@openshift-ci openshift-ci Bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels Jul 21, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 21, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2108699, which is invalid:

  • expected the bug to target the "4.8.z" release, but it targets "---" instead
  • expected Bugzilla bug 2108699 to depend on a bug targeting a release in 4.9.0, 4.9.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.8] Bug 2108699: storage.conf: remove obsolete option override_kernel_check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@QiWang19
Copy link
Copy Markdown
Member

/bugzilla refresh

@openshift-ci openshift-ci Bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 21, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 21, 2022

@QiWang19: This pull request references Bugzilla bug 2108699, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2027926 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2027926 targets the "4.9.z" release, which is one of the valid target releases: 4.9.0, 4.9.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (schoudha@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 21, 2022

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-upgrade 30536cd link false /test okd-e2e-upgrade
ci/prow/e2e-vsphere-upgrade 30536cd link false /test e2e-vsphere-upgrade
ci/prow/okd-e2e-aws 30536cd link false /test okd-e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sinnykumari
Copy link
Copy Markdown
Contributor

clean backport PR
/approve
/assign @haircommander

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2022
@haircommander
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, openshift-cherrypick-robot, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sunilcio
Copy link
Copy Markdown

/label cherry-pick-approved

@openshift-ci openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 27, 2022
@sunilcio
Copy link
Copy Markdown

/label backport-risk-assessed

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 27, 2022

@sunilcio: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers]

Details

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@QiWang19
Copy link
Copy Markdown
Member

@kikisdeliveryservice @sinnykumari Just let you know this is ready to get in. Please tag it when needed.

@sinnykumari
Copy link
Copy Markdown
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 3, 2022
@openshift-ci openshift-ci Bot merged commit e8195eb into openshift:release-4.8 Aug 3, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 3, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2108699 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.8] Bug 2108699: storage.conf: remove obsolete option override_kernel_check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants