Unpin all pinned dependencies#3403
Conversation
We pinned to a version in cba7aba and there's no rationale listed. Unpin it; every single entry in this list of overrides should really have an explicit rationale.
openshift-ci
Bot
added
the
approved
We pinned to a version in cba7aba and there's no rationale listed. Unpin it; every single entry in this list of overrides should really have an explicit rationale.
We haven't been using it since c792d65
We haven't been using it since c792d65
This was another override introduced in cba7aba without explicit motivation. We compile with the new version. I only see small inoccuous API additions. Unpin it. Everything in the override list should have an explicit rationale.
This was pinned in 215102f with no explicit rationale. Unpin it; this cleans out our override list.
|
I was going to test something out by adding another module to |
|
@cgwalters: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
lgtm - I have a vague memory there that since go modules were newish at the time, these pins were done to make compilation successful |
|
make sense, thanks for the clean-up |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, sinnykumari The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
Unpin go-health vendoring
We pinned to a version in cba7aba
and there's no rationale listed. Unpin it; every single
entry in this list of overrides should really have an explicit
rationale.
Unpin godbus
We pinned to a version in cba7aba and there's no rationale listed.
Unpin it; every single entry in this list of overrides should really
have an explicit rationale.
Remove go-log override
We haven't been using it since c792d65
Remove openshift/cluster-api override
We haven't been using it since c792d65
Unpin opencontainers/runtime-spec
This was another override introduced in
cba7aba
without explicit motivation. We compile with the new version.
I only see small inoccuous API additions.
Unpin it.
Everything in the override list should have an explicit rationale.
Unpin gosec
This was pinned in 215102f
with no explicit rationale.
Unpin it; this cleans out our override list.