[release-4.10] OCPBUGS-5831: Do not allow empty system reserved values

[openshift-cherrypick-robot]

This is an automated cherry-pick of #3459

/assign harche

[openshift-ci-robot]

@openshift-cherrypick-robot: Jira Issue OCPBUGS-4945 has been cloned as Jira Issue OCPBUGS-5831. Retitling PR to link against new bug.
/retitle [release-4.10] OCPBUGS-5831: Do not allow empty system reserved values

Details

In response to this:

This is an automated cherry-pick of #3459

/assign harche

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.10] OCPBUGS-5831: Do not allow empty system reserved values

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-5831, which is invalid:

• expected dependent Jira Issue OCPBUGS-4945 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #3459

/assign harche

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rphillips]

looks like unit tests failed

[harche]

/retest

[yuqi-zhang]

/lgtm
/label backport-risk-assessed
/retest-required

Clean cherry-pick, just waiting on validation, test failures seem unrelated

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[harche]

/jira refresh

[openshift-ci-robot]

@harche: This pull request references Jira Issue OCPBUGS-5831, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.10.z) matches configured target version for branch (4.10.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-4945 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
• dependent Jira Issue OCPBUGS-4945 targets the "4.11.z" version, which is one of the valid target versions: 4.11.0, 4.11.z
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (schoudha@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sunilcio]

/label cherry-pick-approved

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD b348c8b and 2 for PR HEAD 4cb6b10 in total

[sdodson]

/retest-required

[harche]

/retest-required

[harche]

/retest-required

[harche]

/retest-required

[harche]

/retest

[harche]

@yuqi-zhang @sinnykumari The CI failure which is preventing this PR from getting merged doesn't seem like related to the change in this PR.

[yuqi-zhang]

Looks like https://prow.ci.openshift.org/job-history/gs/origin-ci-test/pr-logs/directory/pull-ci-openshift-machine-config-operator-release-4.10-e2e-agnostic-upgrade is a bit low in pass rate.

https://prow.ci.openshift.org/pr-history/?org=openshift&repo=machine-config-operator&pr=3487 most of those seem to be pods should successfully create sandboxes by not timing out except one. Giving one more run to see if we can get it through, otherwise we can override

/test e2e-agnostic-upgrade

[openshift-ci]

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-single-node	4cb6b10	link	false	/test e2e-aws-single-node
ci/prow/e2e-aws-upgrade-single-node	4cb6b10	link	false	/test e2e-aws-upgrade-single-node
ci/prow/okd-e2e-gcp-op	4cb6b10	link	false	/test okd-e2e-gcp-op
ci/prow/e2e-aws-disruptive	4cb6b10	link	false	/test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[harche]

@yuqi-zhang those tests failed again, would it be a good idea to override them?

[yuqi-zhang]

/override ci/prow/e2e-aws

Already had a passing run, no need to wait for infra flakes to resolve

[sdodson]

/override ci/prow/e2e-aws

The bot probably ignores me, but I'll try to apply a fresh override.

[openshift-ci]

@sdodson: sdodson unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight.

Details

In response to this:

/override ci/prow/e2e-aws

The bot probably ignores me, but I'll try to apply a fresh override.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yuqi-zhang]

I didn't even see the bot not respond

/override ci/prow/e2e-aws

[openshift-ci]

@yuqi-zhang: Overrode contexts on behalf of yuqi-zhang: ci/prow/e2e-aws

Details

In response to this:

I didn't even see the bot not respond

/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

• openshift/machine-config-operator#3487

Jira Issue OCPBUGS-5831 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #3459

/assign harche

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.