Skip to content

OCPBUGS-15934: unit test ctrrcfg uses *resource.Quantity to use *resource.Quantity#4044

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
QiWang19:verndor-api-fix
Nov 30, 2023
Merged

OCPBUGS-15934: unit test ctrrcfg uses *resource.Quantity to use *resource.Quantity#4044
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
QiWang19:verndor-api-fix

Conversation

@QiWang19
Copy link
Copy Markdown
Member

@QiWang19 QiWang19 commented Nov 21, 2023 •
edited
Loading

Close: OCPBUGS-15934

- What I did
#4012 vendors in the new API and implemented the fix. This PR just added unit tests.

unit tests ctrrcfg using *resource.Quantity
(originally tried to fix through #3815)
- How to verify it

- Description for the changelog

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 21, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@QiWang19
Copy link
Copy Markdown
Member Author

QiWang19 commented Nov 21, 2023

/test all

@QiWang19 QiWang19 changed the title Verndor api fix to use *resource.Quantity Vendor api fix to use *resource.Quantity Nov 21, 2023
@QiWang19
Copy link
Copy Markdown
Member Author

QiWang19 commented Nov 21, 2023

/test all

@QiWang19 QiWang19 changed the title Vendor api fix to use *resource.Quantity OCPBUGS-15934: Vendor api fix to use *resource.Quantity Nov 21, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 21, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 21, 2023

@QiWang19: This pull request references Jira Issue OCPBUGS-15934, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lyman9966

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested a review from lyman9966 November 21, 2023 23:51
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 21, 2023

@QiWang19: This pull request references Jira Issue OCPBUGS-15934, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lyman9966

Details

In response to this:

Close: OCPBUGS-15934

- What I did
Vendor api fix to use *resource.Quantity
- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@QiWang19 QiWang19 marked this pull request as ready for review November 21, 2023 23:57
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2023
@QiWang19
Copy link
Copy Markdown
Member Author

QiWang19 commented Nov 22, 2023

/hold
This can go after #4003

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2023
@QiWang19 QiWang19 mentioned this pull request Nov 27, 2023
Closed
@QiWang19
Test ctrrcfg uses *resource.Quantity
287c0d6 
Signed-off-by: Qi Wang <qiwan@redhat.com>
@QiWang19 QiWang19 changed the title OCPBUGS-15934: Vendor api fix to use *resource.Quantity OCPBUGS-15934: unit test ctrrcfg uses *resource.Quantity to use *resource.Quantity Nov 29, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 29, 2023

@QiWang19: This pull request references Jira Issue OCPBUGS-15934, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lyman9966

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Close: OCPBUGS-15934

- What I did
unit tests ctrrcfg using *resource.Quantity
(originally tried to fix through #3815)
- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jkyros
Copy link
Copy Markdown
Member

jkyros commented Nov 29, 2023

@QiWang19 it looks like #4012 has merged, and it contained the API bump I wanted in #4003 so I closed mine.

What Charlie did in #4012 PR is almost exactly what I was doing in #4003, so you should now be free to resume what you are doing here. Thank you for your patience/sorry for the trouble 😄

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2023
yuqi-zhang
yuqi-zhang approved these changes Nov 29, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This was fixed in API already, having these additional tests should be a safe change which won't require additional verification in the MCO

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: QiWang19, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 29, 2023

/retest-required

Remaining retests: 0 against base HEAD 16b16ef and 2 for PR HEAD 287c0d6 in total

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 30, 2023

/retest-required

Remaining retests: 0 against base HEAD 2fc78f7 and 1 for PR HEAD 287c0d6 in total

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 30, 2023

@QiWang19: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack 7928c9f link false /test e2e-openstack
ci/prow/okd-scos-e2e-aws-ovn 287c0d6 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit bce791e into openshift:master Nov 30, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 30, 2023

@QiWang19: Jira Issue OCPBUGS-15934: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-15934 has been moved to the MODIFIED state.

Details

In response to this:

Close: OCPBUGS-15934

- What I did
#4012 vendors in the new API and implemented the fix. This PR just added unit tests.

unit tests ctrrcfg using *resource.Quantity
(originally tried to fix through #3815)
- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 30, 2023

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-proxy-pull-test-container-v4.15.0-202311301610.p0.gbce791e.assembly.stream for distgit openshift-proxy-pull-test.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

openshift-merge-robot commented Dec 2, 2023

Fix included in accepted release 4.15.0-0.nightly-2023-12-02-123536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

@lyman9966 lyman9966 Awaiting requested review from lyman9966

@cgwalters cgwalters Awaiting requested review from cgwalters

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@yuqi-zhang yuqi-zhang

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@QiWang19 @openshift-ci-robot @jkyros @openshift-bot @openshift-merge-robot @yuqi-zhang