OCPNODE-1632: Bump k8s api to v0.29.0 by QiWang19 · Pull Request #4119 · openshift/machine-config-operator

QiWang19 · 2024-01-14T19:45:07Z

- What I did
Update go.mod openshfit/api to get in API for sigstore CRDs, imagepolicy and clusterimagepolicy.
- How to verify it

- Description for the changelog

openshift-ci · 2024-01-14T19:45:12Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

QiWang19 · 2024-01-14T19:45:17Z

/test all

cdoern

Seems good. However, I do want to be wary about k8s bumps and go version bumps. In testing, bumping k8s hasn't gone smoothly for me so we may want to run some extra tests

QiWang19 · 2024-01-15T17:07:06Z

/retest-required

cdoern · 2024-01-15T19:36:15Z

@QiWang19 please squash into one commit if this is ready to merge. The existing aws-ovn-upgrade failure seems like a flake. I am going to re-run

/test e2e-aws-ovn-upgrade

make go-deps go mod vendor Signed-off-by: Qi Wang <qiwan@redhat.com>

QiWang19 · 2024-01-15T19:54:27Z

/retest-required

QiWang19 · 2024-01-16T14:15:14Z

/retest

QiWang19 · 2024-01-16T14:15:42Z

@cdoern PTAL

QiWang19 · 2024-01-16T20:29:29Z

/retest

QiWang19 · 2024-01-17T10:34:05Z

/retest

openshift-ci-robot · 2024-01-18T20:12:27Z

@QiWang19: This pull request references OCPNODE-1632 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

- What I did
Update go.mod openshfit/api to get in API for sigstore CRDs, imagepolicy and clusterimagepolicy.
- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

QiWang19 · 2024-01-18T20:13:34Z

/retest-required

QiWang19 · 2024-01-18T20:15:12Z

@cdoern @yuqi-zhang Can we get this in?

yuqi-zhang

/lgtm
/override ci/prow/e2e-gcp-op-single-node

Changes look safe, let's get the bump in early to facilitate later work

openshift-ci · 2024-01-18T21:40:54Z

@yuqi-zhang: Overrode contexts on behalf of yuqi-zhang: ci/prow/e2e-gcp-op-single-node

Details

In response to this:

/lgtm
/override ci/prow/e2e-gcp-op-single-node

Changes look safe, let's get the bump in early to facilitate later work

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2024-01-18T21:41:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: QiWang19, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2024-01-18T22:13:54Z

/retest-required

Remaining retests: 0 against base HEAD 9fb0e62 and 2 for PR HEAD 0f13b7a in total

hexfusion · 2024-01-19T03:57:40Z

/retest

openshift-ci-robot · 2024-01-19T09:55:59Z

/retest-required

Remaining retests: 0 against base HEAD 6745e60 and 1 for PR HEAD 0f13b7a in total

hexfusion · 2024-01-19T11:11:56Z

/test e2e-gcp-op

QiWang19 · 2024-01-19T17:23:37Z

/test e2e-gcp-op

openshift-ci-robot · 2024-01-19T23:30:20Z

/retest-required

Remaining retests: 0 against base HEAD 139e1d0 and 0 for PR HEAD 0f13b7a in total

openshift-ci-robot · 2024-01-20T00:43:54Z

/hold

Revision 0f13b7a was retested 3 times: holding

mkowalski · 2024-01-22T12:55:17Z

/retest

Merging this will fix https://issues.redhat.com/browse/OCPBUGS-24573

mkowalski · 2024-01-22T15:11:46Z

e2e-gcp-op-single-node job is permafailing since 20 December 2023, should be still marked as required in this repo?

QiWang19 · 2024-01-22T15:13:23Z

@yuqi-zhang PTAL

e2e-gcp-op-single-node job is permafailing since 20 December 2023, should be still marked as required in this repo?

yuqi-zhang · 2024-01-22T15:41:28Z

I think so, https://issues.redhat.com/browse/OCPBUGS-26489 is the bug, and it's blocking any gcp-single-node deployments, so it's a good indicator. The fix has yet to be applied.

The MCO team will reconsider the value of this job on the MCO repo, though, maybe best as a release informing job instead

/hold cancel
/override ci/prow/e2e-gcp-op-single-node

openshift-ci · 2024-01-22T15:59:12Z

@yuqi-zhang: Overrode contexts on behalf of yuqi-zhang: ci/prow/e2e-gcp-op-single-node

Details

In response to this:

I think so, https://issues.redhat.com/browse/OCPBUGS-26489 is the bug, and it's blocking any gcp-single-node deployments, so it's a good indicator. The fix has yet to be applied.

The MCO team will reconsider the value of this job on the MCO repo, though, maybe best as a release informing job instead

/hold cancel
/override ci/prow/e2e-gcp-op-single-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2024-01-22T18:44:50Z

@QiWang19: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2024-01-23T11:47:18Z

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-proxy-pull-test-container-v4.16.0-202401230706.p0.g1cb3198.assembly.stream for distgit openshift-proxy-pull-test.
All builds following this will include this PR.

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 14, 2024

QiWang19 marked this pull request as ready for review January 14, 2024 19:49

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 14, 2024

openshift-ci Bot requested review from dkhater-redhat and sinnykumari January 14, 2024 19:51

cdoern reviewed Jan 15, 2024

View reviewed changes

Comment thread go.mod

Comment thread go.mod

QiWang19 force-pushed the update-api branch from dbcb4b8 to 5a3d8f9 Compare January 15, 2024 17:16

QiWang19 changed the title ~~Update go.mod~~ Bump k8s api to v0.29.0 Jan 15, 2024

Bump k8s api to v0.29.0

0f13b7a

make go-deps go mod vendor Signed-off-by: Qi Wang <qiwan@redhat.com>

QiWang19 force-pushed the update-api branch from 5a3d8f9 to 0f13b7a Compare January 15, 2024 19:45

mkowalski mentioned this pull request Jan 16, 2024

OCPBUGS-24573: upgrade API after extending ControllerConfig CRD #4122

Closed

QiWang19 changed the title ~~Bump k8s api to v0.29.0~~ OCPNODE-1632: Bump k8s api to v0.29.0 Jan 18, 2024

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 18, 2024

yuqi-zhang approved these changes Jan 18, 2024

View reviewed changes

openshift-ci Bot assigned yuqi-zhang Jan 18, 2024

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2024

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2024

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2024

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2024

openshift-merge-bot Bot merged commit 1cb3198 into openshift:master Jan 22, 2024

jkyros mentioned this pull request Jan 22, 2024

MCO-831: added feature gate to mco for on cluster builds #4060

Merged

Conversation

QiWang19 commented Jan 14, 2024

Uh oh!

openshift-ci Bot commented Jan 14, 2024

Uh oh!

QiWang19 commented Jan 14, 2024

Uh oh!

cdoern left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

QiWang19 commented Jan 15, 2024

Uh oh!

cdoern commented Jan 15, 2024

Uh oh!

QiWang19 commented Jan 15, 2024

Uh oh!

QiWang19 commented Jan 16, 2024

Uh oh!

QiWang19 commented Jan 16, 2024

Uh oh!

QiWang19 commented Jan 16, 2024

Uh oh!

QiWang19 commented Jan 17, 2024

Uh oh!

openshift-ci-robot commented Jan 18, 2024 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

QiWang19 commented Jan 18, 2024

Uh oh!

QiWang19 commented Jan 18, 2024

Uh oh!

yuqi-zhang left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Jan 18, 2024

Uh oh!

openshift-ci Bot commented Jan 18, 2024

Uh oh!

openshift-ci-robot commented Jan 18, 2024

Uh oh!

hexfusion commented Jan 19, 2024

Uh oh!

openshift-ci-robot commented Jan 19, 2024

Uh oh!

hexfusion commented Jan 19, 2024

Uh oh!

QiWang19 commented Jan 19, 2024

Uh oh!

openshift-ci-robot commented Jan 19, 2024

Uh oh!

openshift-ci-robot commented Jan 20, 2024

Uh oh!

mkowalski commented Jan 22, 2024

Uh oh!

mkowalski commented Jan 22, 2024

Uh oh!

QiWang19 commented Jan 22, 2024

Uh oh!

yuqi-zhang commented Jan 22, 2024

Uh oh!

openshift-ci Bot commented Jan 22, 2024

Uh oh!

openshift-ci Bot commented Jan 22, 2024

Uh oh!

openshift-bot commented Jan 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

openshift-ci-robot commented Jan 18, 2024 •

edited by openshift-ci Bot

Loading