Skip to content

[release-4.13]OCPBUGS-27816: use *resource.Quantity to not automatically set 0#4141

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.13from
QiWang19:backport-resource-quantity-4.13
Jan 29, 2024
Merged

[release-4.13]OCPBUGS-27816: use *resource.Quantity to not automatically set 0#4141
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.13from
QiWang19:backport-resource-quantity-4.13

Conversation

@QiWang19
Copy link
Copy Markdown
Member

- What I did
Backport API fix openshift/api#1656 to 4.13
- How to verify it

- Description for the changelog

Signed-off-by: Qi Wang <qiwan@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jan 23, 2024
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@QiWang19: This pull request references Jira Issue OCPBUGS-27816, which is invalid:

  • expected dependent Jira Issue OCPBUGS-27178 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

- What I did
Backport API fix openshift/api#1656 to 4.13
- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 23, 2024
@openshift-ci openshift-ci Bot requested review from mtrmac and sinnykumari January 23, 2024 20:14
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 23, 2024

@QiWang19: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn c0c72ec link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp-rt c0c72ec link false /test e2e-gcp-rt

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@QiWang19
Copy link
Copy Markdown
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 24, 2024
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@QiWang19: This pull request references Jira Issue OCPBUGS-27816, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-27178 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-27178 targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z
  • bug has dependents

Requesting review from QA contact:
/cc @lyman9966

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested a review from lyman9966 January 24, 2024 12:49
@QiWang19
Copy link
Copy Markdown
Member Author

@yuqi-zhang could you tag this?

@rphillips
Copy link
Copy Markdown
Contributor

/label backport-risk-assessed
/lgtm

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 24, 2024
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
Copy link
Copy Markdown
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems safe to do

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: QiWang19, rphillips, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2024
@lyman9966
Copy link
Copy Markdown

/label qe-approved
test passed:
$ oc get containerruntimeconfig pidlimit -o json | jq '.spec.containerRuntimeConfig'
{
"logLevel": "debug",
"pidsLimit": 4096
}

@openshift-ci openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Jan 29, 2024
@sunilcio
Copy link
Copy Markdown

/label cherry-pick-approved

@openshift-ci openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 29, 2024
@openshift-merge-bot openshift-merge-bot Bot merged commit e9778c2 into openshift:release-4.13 Jan 29, 2024
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@QiWang19: Jira Issue OCPBUGS-27816: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-27816 has been moved to the MODIFIED state.

Details

In response to this:

- What I did
Backport API fix openshift/api#1656 to 4.13
- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Copy Markdown
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-proxy-pull-test-container-v4.13.0-202401290532.p0.ge9778c2.assembly.stream for distgit openshift-proxy-pull-test.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

Fix included in accepted release 4.13.0-0.nightly-2024-01-29-212849

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.