pkg/operator: use fake clients in unit#452
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Feb 20, 2019
Merged
pkg/operator: use fake clients in unit#452openshift-merge-robot merged 1 commit intoopenshift:masterfrom
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
Signed-off-by: Antonio Murdaca <runcom@linux.com>
openshift-ci-robot
added
approved
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/test e2e-aws |
Member
Author
|
/retest |
Member
Author
|
aws limit /retest |
Member
|
Bootstrap user flake /retest |
Member
|
AWS is unhappy. |
Member
Author
|
/retest |
Member
Author
|
unit tests fixed in #457 /retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Antonio Murdaca runcom@linux.com
- What I did
I added a wrapper around the ClusterOperators client mainly for unit tests in #442 which turns out to be totally unnecessary since I've learned about fake clients in kube land. This PR removes that wrapper and turns the code back to its state and just use plain fake clients in unit tests which will reduce code and not needed abstractions.
- How to verify it
- Description for the changelog