Skip to content

(Not ready for review) MCO-1501: Add support for custom MCPs in MCN#4835

Closed
isabella-janssen wants to merge 37 commits intoopenshift:masterfrom
isabella-janssen:mco-1501
Closed

(Not ready for review) MCO-1501: Add support for custom MCPs in MCN#4835
isabella-janssen wants to merge 37 commits intoopenshift:masterfrom
isabella-janssen:mco-1501

Conversation

@isabella-janssen
Copy link
Copy Markdown
Member

@isabella-janssen isabella-janssen commented Feb 6, 2025

- What I did
Added support for custom MCPs in the MCN feature.

- How to verify it

- Description for the changelog
MCO-1501: Add support for custom MCPs in the MCN feature

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 6, 2025
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 6, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 6, 2025

@isabella-janssen: This pull request references MCO-1501 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 6, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@isabella-janssen
Copy link
Copy Markdown
Member Author

/test all

@isabella-janssen
Copy link
Copy Markdown
Member Author

/retest-required

@isabella-janssen
Copy link
Copy Markdown
Member Author

/retest-required

@isabella-janssen
Copy link
Copy Markdown
Member Author

/test e2e-aws-ovn

@isabella-janssen
Copy link
Copy Markdown
Member Author

/test e2e-aws-ovn

@isabella-janssen
Copy link
Copy Markdown
Member Author

/test e2e-aws-ovn

1 similar comment
@isabella-janssen
Copy link
Copy Markdown
Member Author

/test e2e-aws-ovn

@isabella-janssen
Copy link
Copy Markdown
Member Author

/test e2e-aws-ovn

@isabella-janssen
Copy link
Copy Markdown
Member Author

/test e2e-aws-ovn

@isabella-janssen
Copy link
Copy Markdown
Member Author

/test e2e-aws-ovn

@isabella-janssen
Copy link
Copy Markdown
Member Author

/test e2e-aws-ovn

@isabella-janssen
Copy link
Copy Markdown
Member Author

/test all

@isabella-janssen
Copy link
Copy Markdown
Member Author

/test e2e-gcp-op-single-node

@isabella-janssen
Copy link
Copy Markdown
Member Author

/test required

@isabella-janssen
Copy link
Copy Markdown
Member Author

/test e2e-aws-ovn

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2025
@isabella-janssen
Copy link
Copy Markdown
Member Author

/test all

@isabella-janssen
Copy link
Copy Markdown
Member Author

/test all

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 14, 2025

@isabella-janssen: This pull request references MCO-1501 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

- What I did
Added support for custom MCPs in the MCN feature.

- How to verify it

- Description for the changelog
MCO-1501: Add support for custom MCPs in the MCN feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 14, 2025

@isabella-janssen: This pull request references MCO-1501 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

- What I did
Added support for custom MCPs in the MCN feature.

- How to verify it

- Description for the changelog
MCO-1501: Add support for custom MCPs in the MCN feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@isabella-janssen
Copy link
Copy Markdown
Member Author

/test all

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 17, 2025

@isabella-janssen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 45c3cb5 link true /test verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@isabella-janssen isabella-janssen force-pushed the mco-1501 branch 2 times, most recently from 63e5584 to 4c5a795 Compare February 24, 2025 19:14
@isabella-janssen
Copy link
Copy Markdown
Member Author

/close

closing in favor of #4876

@openshift-ci openshift-ci Bot closed this Feb 24, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 24, 2025

@isabella-janssen: Closed this PR.

Details

In response to this:

/close

closing in favor of #4876

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@isabella-janssen isabella-janssen deleted the mco-1501 branch May 15, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants