pkg/operator: don't check version for sub MC in pools#488
pkg/operator: don't check version for sub MC in pools#488runcom wants to merge 2 commits intoopenshift:masterfrom
Conversation
Signed-off-by: Antonio Murdaca <runcom@linux.com>
Signed-off-by: Antonio Murdaca <runcom@linux.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: runcom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@runcom: The following test failed for commit f578f1b, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
- What I did
The code wasn't honoring the
versionCheckRequiredfor checking sub-MCs in pools. The main MC for the pool must be correctly generated by the correct controller version, that shouldn't be true for sub MCs?Ref: #487
side note: we should also land #385 somehow
- How to verify it
- Description for the changelog