(not ready for review) OCPBUGS-52302: Fix timing of Spec.ConfigVersion.Desired update in MCN

[isabella-janssen]

Closes: OCPBUGS-52302

- What I did
This moves the MCN spec update earlier in the update flow (before the compatibility check is started) to align with the intended functionality as highlighted in the enhancement & API discussions on the intent of the field.

- How to verify it

1. Create cluster with tech preview enabled.
2. Apply a MC.
3. Watch the MCN during the update. The Spec.ConfigVersion.Desired value should update before Status.ConfigVersion.Desired.
   To see the full MCN object

$ oc describe machineconfignode/<node-name>

**The DESIREDCONFIG column in the following command is populated using Spec.ConfigVersion.Desired and should flip before the UPDATEPREPARED column flips to True.

$ oc get machineconfignodes -o wide

- Description for the changelog
OCPBUGS-52302: Fix timing of Spec.ConfigVersion.Desired update in MCN

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@isabella-janssen: This pull request references Jira Issue OCPBUGS-52302, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Closes: OCPBUGS-52302

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [isabella-janssen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[isabella-janssen]

/jira refresh

[openshift-ci-robot]

@isabella-janssen: This pull request references Jira Issue OCPBUGS-52302, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[isabella-janssen]

/hold

This PR should be reviewed and tested after #4876 is merged in as this bug builds on changes made for MCO-1501.

[isabella-janssen]

/unhold

Dependency PR merged.

[isabella-janssen]

/jira refresh

[openshift-ci-robot]

@isabella-janssen: This pull request references Jira Issue OCPBUGS-52302, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.0) matches configured target version for branch (4.20.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[isabella-janssen]

/retest-required

[openshift-ci]

@isabella-janssen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-hypershift-techpreview	a26359f	link	false	/test e2e-hypershift-techpreview
ci/prow/e2e-aws-ovn-windows	a26359f	link	false	/test e2e-aws-ovn-windows
ci/prow/e2e-agent-compact-ipv4	a26359f	link	false	/test e2e-agent-compact-ipv4
ci/prow/okd-scos-e2e-aws-ovn	a26359f	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn	a26359f	link	true	/test e2e-aws-ovn
ci/prow/e2e-gcp-op-single-node	a26359f	link	true	/test e2e-gcp-op-single-node
ci/prow/e2e-azure-ovn-upgrade-out-of-change	a26359f	link	false	/test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-gcp-op-techpreview	a26359f	link	false	/test e2e-gcp-op-techpreview
ci/prow/verify	a26359f	link	true	/test verify
ci/prow/e2e-aws-ovn-upgrade-out-of-change	a26359f	link	false	/test e2e-aws-ovn-upgrade-out-of-change
ci/prow/e2e-gcp-op-ocl	a26359f	link	false	/test e2e-gcp-op-ocl
ci/prow/e2e-gcp-op	a26359f	link	true	/test e2e-gcp-op
ci/prow/e2e-hypershift	a26359f	link	true	/test e2e-hypershift

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[isabella-janssen]

/close

Closing in favor of #5121.

[openshift-ci]

@isabella-janssen: Closed this PR.

Details

In response to this:

/close

Closing in favor of #5121.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@isabella-janssen: This pull request references Jira Issue OCPBUGS-52302. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Closes: OCPBUGS-52302

- What I did
This moves the MCN spec update earlier in the update flow (before the compatibility check is started) to align with the intended functionality as highlighted in the enhancement & API discussions on the intent of the field.

- How to verify it

1. Create cluster with tech preview enabled.
2. Apply a MC.
3. Watch the MCN during the update. The Spec.ConfigVersion.Desired value should update before Status.ConfigVersion.Desired.
   To see the full MCN object

$ oc describe machineconfignode/<node-name>

**The DESIREDCONFIG column in the following command is populated using Spec.ConfigVersion.Desired and should flip before the UPDATEPREPARED column flips to True.

$ oc get machineconfignodes -o wide

- Description for the changelog
OCPBUGS-52302: Fix timing of Spec.ConfigVersion.Desired update in MCN

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.