MCO-1522: Adapt MCO to use PIS V1 API by RishabhSaini · Pull Request #4934 · openshift/machine-config-operator

RishabhSaini · 2025-03-20T21:41:28Z

Bumps the API version
Bumps the client-go version
Modify the MCC, MCD and Tests to include the V1 PIS API

openshift-ci-robot · 2025-03-20T21:41:32Z

@RishabhSaini: This pull request references MCO-1522 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-03-20T21:43:33Z

@RishabhSaini: This pull request references MCO-1522 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Bumps the API version
Bumps the client-go version (currently points to PR branch, needs to point to master when merged)
Modify the MCC, MCD and Tests to include the V1 PIS API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

RishabhSaini · 2025-03-20T22:08:06Z

/test unit

RishabhSaini · 2025-03-21T00:20:48Z

Realized that a lot of caches where a miss since strings.TrimSpace was needed

RishabhSaini · 2025-03-24T21:32:16Z

/retest-required

isabella-janssen · 2025-03-27T23:35:17Z

Bumps the client-go version (currently points to PR branch, needs to point to master when merged)

Is comment out of date? It looks like openshift/client-go#314 merged and this appears to be pointing to the corresponding commit (f0faeb0f2f2e3b944101467a5eda96bc4fffe1e9)?

If so, lgtm but I'd defer final approval to others on the team.

openshift-ci-robot · 2025-03-28T15:49:46Z

@RishabhSaini: This pull request references MCO-1522 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Bumps the API version
Bumps the client-go version
Modify the MCC, MCD and Tests to include the V1 PIS API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

RishabhSaini · 2025-03-28T15:50:11Z

Bumps the client-go version (currently points to PR branch, needs to point to master when merged)

Is comment out of date? It looks like openshift/client-go#314 merged and this appears to be pointing to the corresponding commit (f0faeb0f2f2e3b944101467a5eda96bc4fffe1e9)?

If so, lgtm but I'd defer final approval to others on the team.

You are right, I have updated the comment to reflect this

go.mod: Update the API and client-go pinned_image_set: use the v1 instead of v1alpha1 PIS Bump API and Client Go to latest

RishabhSaini · 2025-03-28T16:01:49Z

Fixed the typo mentioned here: #4948 (comment)

RishabhSaini · 2025-03-28T16:15:10Z

/test bootstrap-unit

openshift-ci · 2025-03-28T20:19:34Z

@RishabhSaini: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/bootstrap-unit	`5e2b725`	link	false	`/test bootstrap-unit`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

djoshy

Looks good to me, with 1 non blocking question.

And sort of a minor nit, breaking out the vendor and the remaining changes into separate commits makes reviewing and looking at history a bit easier, but again this is also non blocking 😄

/lgtm

djoshy · 2025-03-29T13:14:25Z

 			return ctx.Err()
 		default:
-			image := imageRef.Name
+			image := strings.TrimSpace(string(imageRef.Name))


Could you clarify why this change was necessary? Some sort of new API validation?

+1 Same, I'd like to know why we need this now. I see that the trimming is performed to the UID field too, that, iiuc, it's generated by k8s and cannot have whitespaces.

openshift-ci · 2025-03-29T13:21:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, RishabhSaini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [RishabhSaini,djoshy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2025-03-31T19:33:06Z

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.19.0-202503311810.p0.gf46921d.assembly.stream.el9.
All builds following this will include this PR.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 20, 2025

openshift-ci Bot requested review from dkhater-redhat and umohnani8 March 20, 2025 21:42

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2025

RishabhSaini force-pushed the pisAPI branch from b384f8c to 5ca7a1a Compare March 21, 2025 00:17

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2025

RishabhSaini force-pushed the pisAPI branch from 5ca7a1a to 54a8d13 Compare March 21, 2025 00:19

RishabhSaini force-pushed the pisAPI branch from 54a8d13 to 5f25284 Compare March 21, 2025 00:31

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2025

RishabhSaini force-pushed the pisAPI branch from 5f25284 to cc1ddb5 Compare March 24, 2025 15:41

RishabhSaini mentioned this pull request Mar 28, 2025

OCPBUGS-52656: Update the MCN PIS status of only the primary pool #4948

Merged

start: Use v1 API for the PIS controller

5e2b725

go.mod: Update the API and client-go pinned_image_set: use the v1 instead of v1alpha1 PIS Bump API and Client Go to latest

RishabhSaini force-pushed the pisAPI branch from cc1ddb5 to 5e2b725 Compare March 28, 2025 16:00

djoshy approved these changes Mar 29, 2025

View reviewed changes

openshift-ci Bot assigned djoshy Mar 29, 2025

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2025

openshift-merge-bot Bot merged commit f46921d into openshift:main Mar 31, 2025
16 of 17 checks passed

djoshy mentioned this pull request Apr 1, 2025

MCO-1630: Generate v1 crds for PIS openshift/api#2257

Merged

Conversation

RishabhSaini commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 20, 2025 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 20, 2025 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RishabhSaini commented Mar 20, 2025

Uh oh!

RishabhSaini commented Mar 21, 2025

Uh oh!

RishabhSaini commented Mar 24, 2025

Uh oh!

isabella-janssen commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 28, 2025 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RishabhSaini commented Mar 28, 2025

Uh oh!

RishabhSaini commented Mar 28, 2025

Uh oh!

RishabhSaini commented Mar 28, 2025

Uh oh!

openshift-ci Bot commented Mar 28, 2025

Uh oh!

djoshy left a comment

Choose a reason for hiding this comment

Uh oh!

djoshy Mar 29, 2025

Choose a reason for hiding this comment

Uh oh!

pablintino Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Mar 29, 2025

Uh oh!

Uh oh!

openshift-bot commented Mar 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

RishabhSaini commented Mar 20, 2025 •

edited

Loading

openshift-ci-robot commented Mar 20, 2025 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Mar 20, 2025 •

edited by openshift-ci Bot

Loading

isabella-janssen commented Mar 27, 2025 •

edited

Loading

openshift-ci-robot commented Mar 28, 2025 •

edited by openshift-ci Bot

Loading