Skip to content

NO-ISSUE: MCN changes for API validation#4949

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
isabella-janssen:updateMCNforAPIvalidation
Mar 26, 2025
Merged

NO-ISSUE: MCN changes for API validation#4949
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
isabella-janssen:updateMCNforAPIvalidation

Conversation

@isabella-janssen
Copy link
Copy Markdown
Member

@isabella-janssen isabella-janssen commented Mar 25, 2025

- What I did
Update the NotYetSet constant used throughout the upgrade monitor to match the validation enforced by the updated MCN API.

- How to verify it
Launch cluster with this and the API PR.

launch 4.19,openshift/api#2201,openshift/machine-config-operator#4949 aws,techpreview

- Description for the changelog
Upgrade monitor: Update default NotYetSet placeholder constant

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 25, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@isabella-janssen: This pull request explicitly references no jira issue.

Details

In response to this:

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from cheesesashimi and djoshy March 25, 2025 17:42
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2025
@isabella-janssen
Copy link
Copy Markdown
Member Author

/label acknowledge-critical-fixes-only

Necessary for the MCN v1alpha1 PR tests to pass.

@openshift-ci openshift-ci Bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Mar 25, 2025
@isabella-janssen isabella-janssen force-pushed the updateMCNforAPIvalidation branch from fc5e3ff to 3549f56 Compare March 25, 2025 18:59
@djoshy
Copy link
Copy Markdown
Contributor

djoshy commented Mar 25, 2025

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, isabella-janssen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [djoshy,isabella-janssen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 53e78f3 and 2 for PR HEAD 3549f56 in total

@isabella-janssen
Copy link
Copy Markdown
Member Author

/retest-required

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 26, 2025

@isabella-janssen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade-out-of-change 3549f56 link false /test e2e-aws-ovn-upgrade-out-of-change
ci/prow/okd-scos-e2e-aws-ovn 3549f56 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-azure-ovn-upgrade-out-of-change 3549f56 link false /test e2e-azure-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit dadb568 into openshift:main Mar 26, 2025
14 of 17 checks passed
@isabella-janssen isabella-janssen deleted the updateMCNforAPIvalidation branch March 26, 2025 02:58
@openshift-bot
Copy link
Copy Markdown
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.20.0-202503260442.p0.gdadb568.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants