*: Update "MachinePool" -> "MachineConfigPool" and similar#513
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Mar 20, 2019
Merged
Conversation
There seems to have been some initial uncertainty about what this would be called, with MachinePool first landing in 30d522f (docs: add initial documentation of design, 2018-07-25) and MachineConfigPool first landing in cfc9660 (pkg/apis: add machineconfiguration.openshift.io apis, 2018-07-26, openshift#2). This commit consolidates us around MachineConfigPool, except for the machine-pools/ bootstrap path (since changing that would require consumer updates).
openshift-ci-robot
added
the
approved
openshift-ci-robot
added
the
size/M
kikisdeliveryservice
requested review from
cgwalters and
runcom
and removed request for
abhinavdahiya and
smarterclayton
Contributor
|
@wking I still see |
Contributor
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
Member
Author
I'm fine diverging. The installer's |
Contributor
|
Also since this is not a bug fix it seems like this should be against the 4.1 branch @runcom ? |
Member
|
Most of the changes look trivial but I'm fine deferring to 4.1. |
Member
|
I don't see a reason not to do this now. /lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Member
Author
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to have been some initial uncertainty about what this would be called, with
MachinePoolfirst landing in 30d522f andMachineConfigPoolfirst landing in cfc9660 (#2). This commit consolidates us aroundMachineConfigPool, except for themachine-pools/bootstrap path (since changing that would require consumer updates).