Skip to content

[release-4.19] OCPBUGS-64922: Update timing of MCN desired config spec update to align with node annotation setting#5404

Closed
openshift-cherrypick-robot wants to merge 1 commit intoopenshift:release-4.19from
openshift-cherrypick-robot:cherry-pick-5367-to-release-4.19
Closed

[release-4.19] OCPBUGS-64922: Update timing of MCN desired config spec update to align with node annotation setting#5404
openshift-cherrypick-robot wants to merge 1 commit intoopenshift:release-4.19from
openshift-cherrypick-robot:cherry-pick-5367-to-release-4.19

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #5367

/assign isabella-janssen

…e to node controller to align with annotation setting timing
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-59766 has been cloned as Jira Issue OCPBUGS-64922. Will retitle bug to link to clone.
/retitle [release-4.19] OCPBUGS-64922: Update timing of MCN desired config spec update to align with node annotation setting

Details

In response to this:

This is an automated cherry-pick of #5367

/assign isabella-janssen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.19] OCPBUGS-59766: Update timing of MCN desired config spec update to align with node annotation setting [release-4.19] OCPBUGS-64922: Update timing of MCN desired config spec update to align with node annotation setting Nov 11, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 11, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-64922, which is invalid:

  • expected dependent Jira Issue OCPBUGS-59766 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #5367

/assign isabella-janssen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign yuqi-zhang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@isabella-janssen
Copy link
Copy Markdown
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 12, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@isabella-janssen: This pull request references Jira Issue OCPBUGS-64922, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-59766 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-59766 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
  • bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested a review from sergiordlr November 12, 2025 12:35
@isabella-janssen
Copy link
Copy Markdown
Member

/retest-required

@isabella-janssen
Copy link
Copy Markdown
Member

/test e2e-aws-ovn

@isabella-janssen
Copy link
Copy Markdown
Member

/test e2e-aws-ovn-upgrade

@isabella-janssen
Copy link
Copy Markdown
Member

/retest-required

@isabella-janssen
Copy link
Copy Markdown
Member

/test verify

@isabella-janssen
Copy link
Copy Markdown
Member

/test unit

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 21, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/bootstrap-unit 92fa8f9 link false /test bootstrap-unit
ci/prow/okd-scos-e2e-aws-ovn 92fa8f9 link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-scos-images 92fa8f9 link true /test okd-scos-images
ci/prow/periodics-images 92fa8f9 link true /test periodics-images
ci/prow/e2e-aws-ovn 92fa8f9 link true /test e2e-aws-ovn
ci/prow/e2e-gcp-op-single-node 92fa8f9 link true /test e2e-gcp-op-single-node
ci/prow/verify 92fa8f9 link true /test verify
ci/prow/e2e-aws-ovn-upgrade 92fa8f9 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-hypershift 92fa8f9 link true /test e2e-hypershift
ci/prow/images 92fa8f9 link true /test images
ci/prow/unit 92fa8f9 link true /test unit
ci/prow/e2e-gcp-op 92fa8f9 link true /test e2e-gcp-op

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@djoshy
Copy link
Copy Markdown
Contributor

djoshy commented Nov 24, 2025

looks like we're hitting a build issue, might need to do a manual cherrypick

@isabella-janssen
Copy link
Copy Markdown
Member

@djoshy

I think you're right. I tried to deny that possibility but it seems like I'm probably best off opening the manual cherry-pick. Manual cherry-pick coming soon ⏳

@isabella-janssen
Copy link
Copy Markdown
Member

/close

Closing in favor of #5439.

@openshift-ci openshift-ci Bot closed this Nov 24, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 24, 2025

@isabella-janssen: Closed this PR.

Details

In response to this:

/close

Closing in favor of #5439.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-64922. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #5367

/assign isabella-janssen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants