[WIP] AGENT-1326: Add InternalReleaseImage templates generation during the bootstrap (with RenderContext)

[andfasano]

• What I did
  Enhances the machine-config-controller bootstrap command to add conditionally the InternalReleaseImage related templates (based on the presence on the InternalReleaseImage resource and if the related feature gate has been enabled)

• How to verify it
  Add the InternalReleaseImage resource in the bootstrap manifests dir (/etc/mcc/bootstrap) and enable the feature gate.

• Description for the changelog
  Add support for InternalReleaseImage resource

[openshift-ci-robot]

@andfasano: This pull request references AGENT-1326 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

• What I did
  Enhances the machine-config-controller bootstrap command to add conditionally the InternalReleaseImage related templates (based on the presence on the InternalReleaseImage resource and if the related feature gate has been enabled)

• How to verify it
  Add the InternalReleaseImage resource in the bootstrap manifests dir (/etc/mcc/bootstrap) and enable the feature gate.

• Description for the changelog
  Add support for InternalReleaseImage resource

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andfasano
Once this PR has been reviewed and has the lgtm label, please assign pablintino for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@andfasano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-deps	842c184	link	true	/test verify-deps
ci/prow/e2e-hypershift	842c184	link	true	/test e2e-hypershift
ci/prow/okd-scos-images	842c184	link	true	/test okd-scos-images
ci/prow/images	842c184	link	true	/test images
ci/prow/bootstrap-unit	842c184	link	false	/test bootstrap-unit
ci/prow/e2e-aws-ovn	842c184	link	true	/test e2e-aws-ovn
ci/prow/e2e-aws-ovn-upgrade	842c184	link	true	/test e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[zaneb]

This would be easier to review if the refactoring to use RenderContext were in a separate commit from the changes to add IRI registry templates.

[openshift-merge-robot]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[andfasano]

Addressed by github.com//pull/5452