mcc: fix spelling of vsphere and update golden files#589
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Mar 28, 2019
Merged
Conversation
openshift-ci-robot
added
the
approved
openshift-ci-robot
added
the
size/L
Contributor
Author
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
kikisdeliveryservice
force-pushed
the
fix-vsphere-spelling
branch
from
daa5f86 to
c6bf978
Compare
Contributor
Author
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Member
|
/approve |
Contributor
Author
|
/retest |
Contributor
Author
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
"vsphere" was mistyped in render_test.go. fixed typo and regenerated golden files.
kikisdeliveryservice
force-pushed
the
fix-vsphere-spelling
branch
from
c6bf978 to
e172477
Compare
openshift-ci-robot
added
size/XS
Contributor
Author
|
ok missed a folder. this is ready now. |
Contributor
Author
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kikisdeliveryservice, LorbusChris, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/retest |
Contributor
Author
|
aws route errors: /test e2e-aws |
Contributor
Author
|
/test e2e-aws |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
While working on #583, noticed that "vsphere" was mistyped as "vpshere" in render_test.go. fixed typo and
regenerated golden files
Related to :#583 (comment)
cc: @runcom