skip test if not linux + hack/Makefile cleanups#595
skip test if not linux + hack/Makefile cleanups#595openshift-merge-robot merged 4 commits intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
approved
runcom
changed the title
I'm occasionally developing from a mac, and found out that test is failing cause it's assuming we're on linux and the kernel wrote the boot id under /proc. It's not the case on osx so just skip the test if that file isn't there. Signed-off-by: Antonio Murdaca <runcom@linux.com>
Signed-off-by: Antonio Murdaca <runcom@linux.com>
Call can fail if network is off try reaching the nodes as happened in https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/595/pull-ci-openshift-machine-config-operator-master-e2e-aws-op/1349 so just return false, nil as we do in other places where we know there may be a network error. Signed-off-by: Antonio Murdaca <runcom@linux.com>
runcom
force-pushed
the
osx-tests
branch
2 times, most recently
from
c0297fa to
e95786a
Compare
|
This is also needed for openshift/release#3332 so we can have a verify job which just calls |
runcom
force-pushed
the
osx-tests
branch
2 times, most recently
from
89982e2 to
c390d03
Compare
Signed-off-by: Antonio Murdaca <runcom@linux.com>
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LorbusChris, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test e2e-aws |
|
these failures have nothing to do with this PR. I'll check the forums to see if they are already reported. ill retest later. |
|
a similar failure has been reported in BZ 1695278. It seems to be happening on every run, so no point of mashing retest. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
openshift-bot is trolling me. 🤣 |
|
/retest |
1 similar comment
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 participants
I'm occasionally developing from a mac, and found out that test is
failing cause it's assuming we're on linux and the kernel wrote the boot
id under /proc. It's not the case on osx so just skip the test if that
file isn't there.
The second commit accounts for an empty rev-parse --show-cdup on osx, and fixes that by testing the path to cd (which is not changing behavior on linux)
The other commits are doing a pass over a cleanup in hack and Makefile in order to start addressing #447 - specifically, we need to avoid stuff like #596
Signed-off-by: Antonio Murdaca runcom@linux.com