Skip to content

Bug 1706625: etcd-quorum-guard reporting extremely high memory usage#705

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
RobertKrawitz:eqg-workaround-bz-1571183
May 7, 2019
Merged

Bug 1706625: etcd-quorum-guard reporting extremely high memory usage#705
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
RobertKrawitz:eqg-workaround-bz-1571183

Conversation

@RobertKrawitz
Copy link
Copy Markdown
Contributor

@RobertKrawitz RobertKrawitz commented May 6, 2019

curl results in heavy dentry cache pollution that gets charged to the eqg's cgroup. The underlying bug is https://bugzilla.redhat.com/show_bug.cgi?id=1571183.

Fixes 1706625.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 6, 2019
@runcom
Copy link
Copy Markdown
Member

runcom commented May 6, 2019

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 6, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, RobertKrawitz, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cgwalters
Copy link
Copy Markdown
Member

cgwalters commented May 6, 2019

Holy $#!@$ what is up with nss-softokn in https://bugzilla.redhat.com/show_bug.cgi?id=1044666 ?

I am not reproducing that offhand in a current centos7 container though.

@RobertKrawitz
Copy link
Copy Markdown
Contributor Author

RobertKrawitz commented May 6, 2019

/retest

@RobertKrawitz
Copy link
Copy Markdown
Contributor Author

RobertKrawitz commented May 6, 2019

what is up with nss-softokn in https://bugzilla.redhat.com/show_bug.cgi?id=1044666 ?

I am not reproducing that offhand in a current centos7 container though.

Wow. Look at this: https://hg.mozilla.org/projects/nss/rev/9934c8faef29

That behavior is deliberate.

@cgwalters
Copy link
Copy Markdown
Member

cgwalters commented May 6, 2019 

     /* how long does it take to test for a non-existant file in our working
      * directory? Allows us to test if we may be on a network file system */

Oh god how is this code installed on the root partition of my hard drive?

@RobertKrawitz
Copy link
Copy Markdown
Contributor Author

RobertKrawitz commented May 6, 2019

/retest

2 similar comments
@RobertKrawitz
Copy link
Copy Markdown
Contributor Author

RobertKrawitz commented May 6, 2019

/retest

@RobertKrawitz
Copy link
Copy Markdown
Contributor Author

RobertKrawitz commented May 7, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit f36fd0b into openshift:master May 7, 2019
@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented May 7, 2019

Please follow the conventions described in previous emails about how to associate bugs with PRs. The PR title must be Bug XXXX: <description>.

@runcom runcom changed the title Work around bz1571183 Bug 1571183: Work around bz1571183 May 7, 2019
@runcom
Copy link
Copy Markdown
Member

runcom commented May 7, 2019

changed to that, @RobertKrawitz can you enhance the title itself?

@RobertKrawitz RobertKrawitz changed the title Bug 1571183: Work around bz1571183 Bug 1571183: etcd-quorum-guard reporting extremely high memory usage May 7, 2019
@RobertKrawitz RobertKrawitz changed the title Bug 1571183: etcd-quorum-guard reporting extremely high memory usage Bug 1706625: etcd-quorum-guard reporting extremely high memory usage May 7, 2019
@spadgett spadgett mentioned this pull request Aug 13, 2019
Merged
@yboaron yboaron mentioned this pull request Aug 20, 2019
Closed
@bcrochet bcrochet mentioned this pull request Aug 26, 2019
Merged
bcrochet pushed a commit to bcrochet/machine-config-operator that referenced this pull request Aug 27, 2019
@yboaronn @bcrochet
[Baremetal and Openstack] avoid excessive dentries due to keepalived …
1b076d0 
…static pod health scripts

curl commands on the keepalived static pod cause a huge amount of memory dentries.
The underlying bug is https://bugzilla.redhat.com/show_bug.cgi?id=1571183.

For more details see:
openshift#705
openshift/openshift-ansible#11829
@vrutkovs vrutkovs mentioned this pull request Apr 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashcrow ashcrow ashcrow approved these changes

@cgwalters cgwalters Awaiting requested review from cgwalters

@runcom runcom Awaiting requested review from runcom

Assignees

@runcom runcom

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@RobertKrawitz @runcom @openshift-ci-robot @cgwalters @smarterclayton @ashcrow @openshift-merge-robot