Bug 1707928: hack/build-go.sh: use just git hashes for building#728
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom May 9, 2019
Merged
Bug 1707928: hack/build-go.sh: use just git hashes for building#728openshift-merge-robot merged 1 commit intoopenshift:masterfrom
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
size/XS
cgwalters
reviewed
May 9, 2019
Member
Author
|
/retest |
Member
Author
|
damn this is failing cause we want a valid semver version |
openshift-ci-robot
added
size/M
Member
Author
|
alright, changed to just have a new field in the version pkg that points to the git hash and use that whenever we need to compare MCC versions. @cgwalters ptal |
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, runcom, squat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
gosh, this is going through another round of testing cause #701 has been merged meanwhile |
Member
Author
That's what we get now, and we easily point to a given MCO git commit when asked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Do not rely on tags (as they may contain timestamps which can cause us to drift)
- How to verify it
- Description for the changelog