Bug 1723928: Add script to generate bootstrap recovery kubeconfig by rphillips · Pull Request #794 · openshift/machine-config-operator

rphillips · 2019-05-24T14:58:57Z

Pick for 4.1 of #792

DR Kubelet recovery script

rphillips · 2019-05-24T15:03:49Z

force pushed to regenerate the templates for 4.1

rphillips · 2019-05-24T15:08:28Z

/cc @hexfusion

hexfusion · 2019-05-24T15:23:49Z

/lgtm

hexfusion · 2019-05-24T15:34:02Z

At this point, we probably need this to be blessed by @smarterclayton if it is going to make 4.1

hexfusion · 2019-05-24T16:59:02Z

/cc @derekwaynecarr not sure if we are past the cutoff.

rphillips · 2019-05-24T17:00:38Z

This can be in 4.1.z if that is easier.

openshift-merge-robot · 2019-06-05T23:22:40Z

/bugzilla refresh

openshift-ci-robot · 2019-06-05T23:22:41Z

@openshift-merge-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

derekwaynecarr · 2019-06-18T21:56:58Z

please link to an appropriate bz targeting 4.1.z and we can include this afterwards.

openshift-ci-robot · 2019-06-25T19:06:57Z

@rphillips: This pull request references an invalid Bugzilla bug:

expected the bug to target the "4.1.z" release, but it targets "---" instead

Details

In response to this:

Bug 1723928: add script to generate bootstrap recovery kubeconfig [pick for 4.1]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rphillips · 2019-06-25T19:09:32Z

@runcom could you review this for 4.1.z? Thanks!

rphillips · 2019-06-25T19:13:53Z

/bugzilla refresh

openshift-ci-robot · 2019-06-25T19:13:58Z

@rphillips: This pull request references an invalid Bugzilla bug:

expected the bug to target the "4.1.z" release, but it targets "---" instead

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rphillips · 2019-06-25T19:15:05Z

/bugzilla refresh

openshift-ci-robot · 2019-06-25T19:15:09Z

@rphillips: This pull request references a valid Bugzilla bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

runcom · 2019-06-26T12:45:08Z

This lgtm and has Sam lgtm but it needs probably eparis label for cherry-pick

/approve

openshift-ci-robot · 2019-06-26T12:45:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, rphillips, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rphillips · 2019-06-26T15:55:11Z

@eparis could you approve this pick for 4.1?

eparis · 2019-06-27T00:10:01Z

This has missed for 4.1.4 and will be re-reviewed next week for 4.1.5.

However, I do not see a BZ against 4.2 which shows that a human has run QE testing against the PR in master, nor do I see a unit/integration/e2e tests which gives confidence in an automated way. I believe you need to clone 1723928 to a new bug, set that to target release 4.2 and work with QE to validate that your work in master functions correctly before re-evaluation next monday.

rphillips · 2019-06-27T15:01:30Z

@eparis the QA tests were done via: https://bugzilla.redhat.com/show_bug.cgi?id=1711910

jwforres · 2019-07-02T02:15:50Z

@rphillips looks like this was not an exact pick from https://github.com/openshift/machine-config-operator/pull/792/files
It looks like the additional files here are just test data for testing the script, is that correct?

crawford · 2019-07-08T20:12:46Z

The test_data is required because 4.1.z doesn't include #749, which removes the need for test_data.

crawford · 2019-07-08T22:15:47Z

From the logs:

time="2019-07-08T21:29:20Z" level=info msg="loading CRDs" port=50051 type=appregistry
time="2019-07-08T21:29:20Z" level=info msg="loading Bundles" port=50051 type=appregistry
time="2019-07-08T21:29:20Z" level=info msg="loading Packages" port=50051 type=appregistry
time="2019-07-08T21:29:20Z" level=fatal msg="error loading manifest from remote registry - amqstreams.v1.2.0 specifies replacement that couldn't be found" port=50051 type=appregistry

This appears to be a remote issue. @kevinrizza is looking into this further. In the meantime...

/retest

openshift-bot · 2019-07-09T00:43:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 24, 2019

openshift-ci-robot requested review from cgwalters and jlebon May 24, 2019 14:59

kubelet: add script to generate bootstrap recovery kubeconfig

c1d159c

rphillips force-pushed the fixes/add_recover_kubeconfig_script_4.1 branch from 0186314 to c1d159c Compare May 24, 2019 15:03

openshift-ci-robot requested a review from hexfusion May 24, 2019 15:08

rphillips changed the title ~~kubelet: add script to generate bootstrap recovery kubeconfig~~ kubelet: add script to generate bootstrap recovery kubeconfig [pick for 4.1] May 24, 2019

openshift-ci-robot assigned hexfusion May 24, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2019

rphillips changed the title ~~kubelet: add script to generate bootstrap recovery kubeconfig [pick for 4.1]~~ DR: add script to generate bootstrap recovery kubeconfig [pick for 4.1] May 24, 2019

rphillips changed the title ~~DR: add script to generate bootstrap recovery kubeconfig [pick for 4.1]~~ Bug 1723928: add script to generate bootstrap recovery kubeconfig [pick for 4.1] Jun 25, 2019

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 25, 2019

rphillips changed the title ~~Bug 1723928: add script to generate bootstrap recovery kubeconfig [pick for 4.1]~~ Bug 1723928: add script to generate bootstrap recovery kubeconfig [pick for 4.1] Jun 25, 2019

rphillips changed the title ~~Bug 1723928: add script to generate bootstrap recovery kubeconfig [pick for 4.1]~~ Bug 1723928: pick for 4.1 - add script to generate bootstrap recovery kubeconfig Jun 25, 2019

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 25, 2019

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 25, 2019

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2019

jwforres changed the title ~~Bug 1723928: pick for 4.1 - add script to generate bootstrap recovery kubeconfig~~ Bug 1723928: Add script to generate bootstrap recovery kubeconfig Jul 2, 2019

crawford added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 8, 2019

openshift-merge-robot merged commit 365c1cf into openshift:release-4.1 Jul 9, 2019

Conversation

rphillips commented May 24, 2019

Uh oh!

rphillips commented May 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rphillips commented May 24, 2019

Uh oh!

hexfusion commented May 24, 2019

Uh oh!

hexfusion commented May 24, 2019

Uh oh!

hexfusion commented May 24, 2019

Uh oh!

rphillips commented May 24, 2019

Uh oh!

openshift-merge-robot commented Jun 5, 2019

Uh oh!

openshift-ci-robot commented Jun 5, 2019

Uh oh!

derekwaynecarr commented Jun 18, 2019

Uh oh!

openshift-ci-robot commented Jun 25, 2019

Uh oh!

rphillips commented Jun 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rphillips commented Jun 25, 2019

Uh oh!

openshift-ci-robot commented Jun 25, 2019

Uh oh!

rphillips commented Jun 25, 2019

Uh oh!

openshift-ci-robot commented Jun 25, 2019

Uh oh!

runcom commented Jun 26, 2019

Uh oh!

openshift-ci-robot commented Jun 26, 2019

Uh oh!

rphillips commented Jun 26, 2019

Uh oh!

eparis commented Jun 27, 2019

Uh oh!

rphillips commented Jun 27, 2019

Uh oh!

jwforres commented Jul 2, 2019

Uh oh!

crawford commented Jul 8, 2019

Uh oh!

crawford commented Jul 8, 2019

Uh oh!

openshift-bot commented Jul 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

rphillips commented May 24, 2019 •

edited

Loading

rphillips commented Jun 25, 2019 •

edited

Loading