Skip to content

controller: don't set cloud provider for baremetal#864

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
stbenjam:cloud
Jun 18, 2019
Merged

controller: don't set cloud provider for baremetal#864
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
stbenjam:cloud

Conversation

@stbenjam
Copy link
Copy Markdown
Member

This causes an error during installation:

Jun 18 16:39:30 master-0 hyperkube[2223]: F0618 16:39:30.475150    2223
server.go:267] failed to run Kubelet: unknown cloud provider "baremetal"

This causes an error during installation:

```
Jun 18 16:39:30 master-0 hyperkube[2223]: F0618 16:39:30.475150    2223
server.go:267] failed to run Kubelet: unknown cloud provider "baremetal"
```
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 18, 2019
@kikisdeliveryservice kikisdeliveryservice changed the title Don't set cloud provider for baremetal controller: don't set cloud provider for baremetal Jun 18, 2019
@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

kikisdeliveryservice commented Jun 18, 2019

Can we have a little more information about this? What will you be using as the value for platform? Have you done a fully successful install by removing this?

@kikisdeliveryservice kikisdeliveryservice self-requested a review June 18, 2019 16:57
@stbenjam
Copy link
Copy Markdown
Member Author

Can we have a little more information about this? What will you be using as the value for platform?

What do you mean by value for platform? Like libvirt, baremetal IPI doesn't have a cloud provider supported by kubelet, so it is set to "". My mistake when I added this in #846

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

My mistake when I added this in #846

Ah didn't realize you were the person who added it.

@stbenjam
Copy link
Copy Markdown
Member Author

@kikisdeliveryservice Do you want me to update the commit msg to match new title?

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2019
@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

this seems fine but will leave it to @cgwalters to lgtm

@cgwalters
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, cgwalters, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9fc6860 into openshift:master Jun 18, 2019
@stbenjam stbenjam deleted the cloud branch June 18, 2019 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants