controller: don't set cloud provider for baremetal#864
controller: don't set cloud provider for baremetal#864openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
This causes an error during installation: ``` Jun 18 16:39:30 master-0 hyperkube[2223]: F0618 16:39:30.475150 2223 server.go:267] failed to run Kubelet: unknown cloud provider "baremetal" ```
|
Can we have a little more information about this? What will you be using as the value for platform? Have you done a fully successful install by removing this? |
What do you mean by value for platform? Like libvirt, baremetal IPI doesn't have a cloud provider supported by kubelet, so it is set to "". My mistake when I added this in #846 |
Ah didn't realize you were the person who added it. |
|
@kikisdeliveryservice Do you want me to update the commit msg to match new title? |
|
this seems fine but will leave it to @cgwalters to lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, cgwalters, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This causes an error during installation: