Take over /usr/bin/pivot too#885
Conversation
openshift-ci-robot
added
size/XS
There was a problem hiding this comment.
nit: $RPM_BUILD_ROOT/%{_bindir}/pivot
Since it exists in the docs, and there's already a nontrivial amount of "muscle memory" around it.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, cgwalters The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| %license LICENSE | ||
| %doc README.md | ||
| %{_libexecdir}/%{name} | ||
| %{_bindir}/pivot |
There was a problem hiding this comment.
isn't this conflicting with https://github.com/openshift/machine-config-operator/blob/master/pkg/daemon/rpm-ostree.go#L132
There was a problem hiding this comment.
Uhm, this slipped through, @cgwalters can you take a super fast look?
There was a problem hiding this comment.
You're totally right but because we aren't auto-building the RPM yet we have time to do a PR to drop the compat code which I think we can do now that a RHCOS bootimage update landed.
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 participants
Since it exists in the docs, and there's already a nontrivial amount
of "muscle memory" around it.