docs: update hacking.md to reflect new commands#958
Merged
openshift-merge-robot merged 1 commit intoJul 12, 2019
Merged
Conversation
openshift-ci-robot
added
the
size/M
openshift-ci-robot
added
the
approved
sgreene570
reviewed
Jul 11, 2019
Contributor
sgreene570
left a comment
sgreene570
left a comment
There was a problem hiding this comment.
This is so much simpler now 😄
kikisdeliveryservice
force-pushed
the
update-hacking-md-commands
branch
from
b55b52b to
6e7bae1
Compare
Contributor
Author
|
note: this is going to fail verify until the fix is merged. |
Update commands in hacking.md since we now only have 1 Dockerfile/mco image. Also add hack/push-image.sh command to hacking.md Related-to: openshift#739 Related-to: openshift#948 Related-to: openshift#950
kikisdeliveryservice
force-pushed
the
update-hacking-md-commands
branch
from
6e7bae1 to
02e38eb
Compare
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kikisdeliveryservice, sgreene570 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update commands in hacking.md since we now only have 1 Dockerfile/mco image.
Also add hack/push-image.sh command to hacking.md
Related-to: #739
Related-to: #948
Related-to: #950