Skip to content

OWNERS#1

Merged
wanghaoran1988 merged 5 commits intomasterfrom
himanshudogra-patch-1
Apr 28, 2020
Merged

OWNERS#1
wanghaoran1988 merged 5 commits intomasterfrom
himanshudogra-patch-1

Conversation

@himanshudogra
Copy link
Copy Markdown
Contributor

No description provided.

@oddtazz
Copy link
Copy Markdown
Contributor

oddtazz commented Apr 28, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2020
@mrbarge
Copy link
Copy Markdown
Contributor

mrbarge commented Apr 28, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2020
@wanghaoran1988
Copy link
Copy Markdown
Member

Could you squash the commits ?

Comment thread OWNERS
approvers:
- mwoodson
- jewzaam
- mrbarge
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add me as a approver?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure adding now.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added you. pls check now.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2020
@oddtazz
Copy link
Copy Markdown
Contributor

oddtazz commented Apr 28, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2020
@wanghaoran1988 wanghaoran1988 merged commit e4c23da into master Apr 28, 2020
@wanghaoran1988 wanghaoran1988 deleted the himanshudogra-patch-1 branch April 28, 2020 06:16
openshift-merge-robot pushed a commit that referenced this pull request Apr 12, 2023
Updating doc with Go 1.19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants