Skip to content

Bump operator-lib to v0.13.0#483

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
ravitri:update-operator-lib
Nov 8, 2024
Merged

Bump operator-lib to v0.13.0#483
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
ravitri:update-operator-lib

Conversation

@ravitri
Copy link
Copy Markdown
Member

@ravitri ravitri commented Nov 6, 2024

What type of PR is this?

(dependency update)

What this PR does / why we need it?

This PR updates the github.com/operator-framework/operator-lib version to v0.13.0. The main reason to do that was to avail the fix for upstream issue operator-framework/operator-lib#156 identified in version v0.12.0.

With the fix in operator-framework/operator-lib#157, we will additionally address the issue scenario of MUO lock not released incase the pod is preempted. If we continue to face the issue ahead as well after rollout of this PR, we can review and consider PR #476 solution further ahead.

Which Jira/Github issue(s) this PR fixes?

Fixes # OSD-25179

Special notes for your reviewer:

This PR would atleast partially address the concern that PR #476 intended to address with a dependency bump so would be ok to close the other PR for time being and get back to it if we still continue to face similar issue.

Pre-checks (if applicable):

  • Tested latest changes against a cluster
  • Included documentation changes with PR

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 6, 2024

@ravitri: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.22%. Comparing base (6a23cb1) to head (a792029).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #483   +/-   ##
=======================================
  Coverage   54.22%   54.22%           
=======================================
  Files         122      122           
  Lines        5953     5953           
=======================================
  Hits         3228     3228           
  Misses       2523     2523           
  Partials      202      202           

@Tafhim
Copy link
Copy Markdown
Contributor

Tafhim commented Nov 8, 2024

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ravitri, Tafhim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit f5833ed into openshift:master Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants