SREP-4721- add ServiceAccount to PKO deployment manifests

[tnierman]

OLM implicitly created the ServiceAccount; PKO requires it to be declared explicitly. Without it the Deployment fails on new clusters.

What type of PR is this?

bug

What this PR does / why we need it?

When MUO is deployed to new clusters, PKO needs to create its managed-upgrade-operator serviceaccount. This adds the required object in order to achieve that

Which Jira/Github issue(s) this PR fixes?

Fixes # https://redhat.atlassian.net/browse/SREP-4721

Special notes for your reviewer:

Pre-checks (if applicable):

• Tested latest changes against a cluster
• Included documentation changes with PR

Summary by CodeRabbit

• Chores
  • Added service account configuration for the managed upgrade operator with operator annotations and collision protection settings.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a6583506-5c70-46fb-a155-f95292776e0a

📥 Commits

Reviewing files that changed from the base of the PR and between fec8505 and 2fe3c90.

📒 Files selected for processing (2)

• deploy_pko/.test-fixtures/config-with-proxy/ServiceAccount-managed-upgrade-operator.yaml
• deploy_pko/ServiceAccount-managed-upgrade-operator.yaml

---

Walkthrough

Two new Kubernetes ServiceAccount manifest files are introduced for the managed-upgrade-operator resource in the openshift-managed-upgrade-operator namespace. Both files define identical ServiceAccount configurations with operator-phase and collision-protection annotations, with one placed in the test fixtures directory and the other in the main deploy directory.

Changes

Cohort / File(s)	Summary
ServiceAccount Manifests deploy_pko/ServiceAccount-managed-upgrade-operator.yaml, deploy_pko/.test-fixtures/config-with-proxy/ServiceAccount-managed-upgrade-operator.yaml	Adds Kubernetes ServiceAccount resource (managed-upgrade-operator) in openshift-managed-upgrade-operator namespace with operator annotations for phase (namespace) and collision protection (IfNoController).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title clearly and directly describes the main change: adding a ServiceAccount to PKO deployment manifests, which matches the actual changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR adds only Kubernetes manifest YAML files, not Ginkgo test code. The check for unstable test names does not apply to YAML configuration files.
Test Structure And Quality	✅ Passed	PR modifies only Kubernetes YAML manifest files with no Ginkgo test code changes, making custom check for test structure not applicable.
Microshift Test Compatibility	✅ Passed	This PR does not add any new Ginkgo e2e tests; it only adds Kubernetes manifest files for ServiceAccount resources. The MicroShift Test Compatibility check applies only when new e2e tests are introduced, which is not the case here.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR only adds Kubernetes YAML manifest files for ServiceAccount configuration with no new Ginkgo e2e tests, making it not applicable to SNO Test Compatibility checks.
Topology-Aware Scheduling Compatibility	✅ Passed	ServiceAccount manifests contain only identity metadata and do not define any scheduling constraints, affinity rules, replica counts, or topology spread constraints that could affect scheduling across different OpenShift topologies.
Ote Binary Stdout Contract	✅ Passed	PR adds only Kubernetes YAML manifest files with no Go code, binaries, or process-level code that could write to stdout.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Pull request only adds Kubernetes YAML manifest files for ServiceAccount resource; no Ginkgo e2e tests introduced, making IPv6/disconnected network compatibility check not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tnierman
Once this PR has been reviewed and has the lgtm label, please assign iamkirkbater for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@tnierman: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/validate	2fe3c90	link	true	/test validate

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.59%. Comparing base (fec8505) to head (2fe3c90).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #604   +/-   ##
=======================================
  Coverage   53.59%   53.59%           
=======================================
  Files         123      123           
  Lines        6165     6165           
=======================================
  Hits         3304     3304           
  Misses       2668     2668           
  Partials      193      193           

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[TheUndeadKing]

please move the phase to RBAC

[TheUndeadKing]

same, please move the phase to RBAC