-
Notifications
You must be signed in to change notification settings - Fork 223
USHIFT-533: Remove role (controlplane/node) config. #1065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USHIFT-533: Remove role (controlplane/node) config. #1065
Conversation
|
/assign @fzdarsky |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, dgrisonnet, oglok The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold Isn’t this PR overshooting a bit? We wanted to ensure this knob isn’t exposed to users yet, not remove the role split (which we’re going to have to implement anyway) and the design discussion? |
|
/hold cancel Looking at this again, after removing the config option the remaining wiring probably isn't awfully relevant. |
|
/retest-required |
|
@benluddy: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Following earlier discussion (#1011 (comment)), let's wait to define the configuration surface until split role support arrives.