Skip to content

Fix missing change of router manifest#1186

Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
fzdarsky:fix-router-rebase
Dec 11, 2022
Merged

Fix missing change of router manifest#1186
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
fzdarsky:fix-router-rebase

Conversation

@fzdarsky
Copy link
Copy Markdown
Contributor

Updates the rebase script to the recent config change separating cluster domain into cluster name and base domain.

Signed-off-by: Frank A. Zdarsky fzdarsky@redhat.com

Signed-off-by: Frank A. Zdarsky <fzdarsky@redhat.com>
@openshift-ci openshift-ci Bot requested review from dhellmann and sallyom December 11, 2022 08:07
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2022
@ggiguash
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fzdarsky, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 11, 2022

@fzdarsky: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants