Skip to content

USHIFT-677: Remove _output on successful rebase #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Dec 13, 2022
Merged

USHIFT-677: Remove _output on successful rebase #1191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions scripts/auto-rebase/rebase.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,6 +691,9 @@ rebase_to() {
else
echo "No changes to buildfiles."
fi

title "# Removing staging directory"
rm -rf "$REPOROOT/_output"
Copy link
Copy Markdown
Contributor

@dhellmann dhellmann Dec 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean the directory is only cleaned up in the full "to" workflow? But if a developer uses the individual commands to fetch images, update manifests, etc. then the temporary directory is not cleaned up? I think that's what we want, but I want to make sure I understand the changes.

Copy link
Copy Markdown
Member Author

@pmtk pmtk Dec 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly. And if anything along the way fails, script won't reach the removal, so (I hope) this addition won't be an annoyance for devs, but will address source RPM issue on our side rather than ART's.

}


Expand Down