USHIFT-247: Generate release-info#1196
Conversation
openshift-ci
Bot
added
the
approved
|
@fzdarsky, can you add a short doc for devs explaing how this information can be used out of the new RPM? |
|
@fzdarsky, please update this doc section with the new RPM |
|
/assign ggiguash |
Done. |
There was a problem hiding this comment.
I wonder why arch names have been replaced: amd64 to x86_64 and arm64 to aarch64. Any specific reason?
There was a problem hiding this comment.
My motivation for this was user experience. The x86_64/aarch64 architecture names are more idiomatic on Linux systems in general and RPM-based distros in particular.
For example, this way users can use $(uname -i) in scripts and avoid conditional logic and substitutions as with the Golang names. It’s also consistent with the RPM package naming scheme.
|
I think it's a very smart approach to solve this problem. |
dhellmann
left a comment
dhellmann
left a comment
There was a problem hiding this comment.
This is pretty much exactly what I had in mind. I had one or two nits, but nothing to hold it up. I know there were some other commenters, so I'll leave a hold along with the approval and you can remove that when everyone else is satisfied.
/lgtm
/hold
There was a problem hiding this comment.
We could move the base info out eventually, too. We shouldn't hold this up over that change, though.
There was a problem hiding this comment.
I agree. I think removing get.sh script forced us to duplicate and spread parsing of this information in other scripts. Let's return the get.sh file
There was a problem hiding this comment.
Moved the base into the JSON, too, so now parsing is uniform and simple.
openshift-ci
Bot
added
the
do-not-merge/hold
|
@fzdarsky, can we please implement 2 changes before we merge this PR?
|
There was a problem hiding this comment.
It would be great if we could also produce a toml snippet so customers just can append that to their blueprints without additional processing if they wanted.
I suggest that as follow up, not now.
The toml is less descriptive for the name of the images, but we could put that in comments.
There was a problem hiding this comment.
May be we should explain the purpose of this; i.e.
This package can be used to find the images consumed by MicroShift in runtime
and embed those into blueprints/ostree images.
fzdarsky
force-pushed
the
generate-release-info
branch
from
b8c101d to
85c9b94
Compare
openshift-merge-robot
added
the
needs-rebase
fzdarsky
force-pushed
the
generate-release-info
branch
from
85c9b94 to
7db55f6
Compare
openshift-merge-robot
removed
the
needs-rebase
Added new |
fzdarsky
force-pushed
the
generate-release-info
branch
from
7db55f6 to
f1cdc37
Compare
|
/hold cancel |
openshift-ci
Bot
removed
the
do-not-merge/hold
Introduces a new subpackage microshift-release-info that contains JSON files with the pull specs of the container images used by the respective MicroShift version. Also moves this release info from code (release_*.go) into a JSON in the assets folder (release-*.json) for more robust processing using jq. That also allows to remove the get.sh script. Updates scripts and docs accordingly. Signed-off-by: Frank A. Zdarsky <fzdarsky@redhat.com>
Signed-off-by: Frank A. Zdarsky <fzdarsky@redhat.com>
fzdarsky
force-pushed
the
generate-release-info
branch
from
f1cdc37 to
8fc3c1d
Compare
|
/lgtm Still get.sh is not re-added as talked in slack. But we can add that back if necessary. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, fzdarsky, mangelajo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@fzdarsky: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
6 participants
Adds a new RPM package "microshift-release-info" that contains JSON files containing the container image digests of the respective MicroShift release, so users can use these digests when creating osbuild-composer blueprints.
As side-effect, moves MicroShift's own release info from the pkg/release/release_*.go into JSON files in the assets/release directory.
Signed-off-by: Frank A. Zdarsky fzdarsky@redhat.com
Closes USHIFT-247