Skip to content

OCPBUGS-7124: Delete microshift RPM files from rhocp repo when building ISO images#1334

Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
ggiguash:fix_image_builder
Feb 7, 2023
Merged

OCPBUGS-7124: Delete microshift RPM files from rhocp repo when building ISO images#1334
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
ggiguash:fix_image_builder

Conversation

@ggiguash
Copy link
Copy Markdown
Contributor

@ggiguash ggiguash commented Feb 7, 2023

Prevent conflicts with MicroShift RPMs from rhocp repo when building ISO images.

Closes OCPBUGS-7124

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 7, 2023
@openshift-ci-robot
Copy link
Copy Markdown

@ggiguash: This pull request references Jira Issue OCPBUGS-7124, which is invalid:

  • expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Prevent conflicts with MicroShift RPMs from rhocp repo when building ISO images.

Closes OCPBUGS-7124

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from pmtk and stlaz February 7, 2023 07:15
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2023
@ggiguash
Copy link
Copy Markdown
Contributor Author

ggiguash commented Feb 7, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 7, 2023
@openshift-ci-robot
Copy link
Copy Markdown

@ggiguash: This pull request references Jira Issue OCPBUGS-7124, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested a review from jogeo February 7, 2023 07:15
@pmtk
Copy link
Copy Markdown
Member

pmtk commented Feb 7, 2023

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ggiguash
Copy link
Copy Markdown
Contributor Author

ggiguash commented Feb 7, 2023

/cherrypick release-4.12

@openshift-cherrypick-robot
Copy link
Copy Markdown

@ggiguash: once the present PR merges, I will cherry-pick it on top of release-4.12 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD c63ec51 and 2 for PR HEAD cf89838 in total

@openshift-merge-robot openshift-merge-robot merged commit db97678 into openshift:main Feb 7, 2023
@openshift-ci-robot
Copy link
Copy Markdown

@ggiguash: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-7124 has been moved to the MODIFIED state.

Details

In response to this:

Prevent conflicts with MicroShift RPMs from rhocp repo when building ISO images.

Closes OCPBUGS-7124

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@ggiguash: new pull request created: #1336

Details

In response to this:

/cherrypick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants