Skip to content

USHIFT-870: do not require kubeconfig to run rebase script #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Feb 14, 2023
Merged

USHIFT-870: do not require kubeconfig to run rebase script #1359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 14 additions & 20 deletions scripts/auto-rebase/rebase.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,43 +132,37 @@ update_lvms_images(){
popd
}

set_openshift_storage_ns(){
local manifest="$1"
local tmp="$(oc create --dry-run=client --namespace=openshift-storage -o yaml -f "${manifest}")"
# assume that if the returned string is nil, it's because the resource is not namespaced. Failures
# like file-not-found will still result in the script exiting with a non-zero code.
if [ -z "$(echo "$tmp" | tr -d '[:space:]' )" ]; then
return 0
fi
echo "$tmp" > "$manifest"
}

update_lvms_manifests() {
local src="${STAGING_DIR}/lvms/amd64"
local dest="${REPOROOT}/assets/components/lvms"
local manifests=(
local cluster_scoped_manifests=(
"topolvm-controller_rbac.authorization.k8s.io_v1_clusterrolebinding.yaml"
"topolvm-controller_rbac.authorization.k8s.io_v1_clusterrole.yaml"
"topolvm-controller_v1_serviceaccount.yaml"
"topolvm-csi-provisioner_rbac.authorization.k8s.io_v1_clusterrole.yaml"
"topolvm-csi-provisioner_rbac.authorization.k8s.io_v1_clusterrolebinding.yaml"
"topolvm-csi-provisioner_rbac.authorization.k8s.io_v1_role.yaml"
"topolvm-csi-provisioner_rbac.authorization.k8s.io_v1_rolebinding.yaml"
"topolvm-csi-resizer_rbac.authorization.k8s.io_v1_clusterrole.yaml"
"topolvm-csi-resizer_rbac.authorization.k8s.io_v1_clusterrolebinding.yaml"
"topolvm-node_rbac.authorization.k8s.io_v1_clusterrole.yaml"
"topolvm-node_rbac.authorization.k8s.io_v1_clusterrolebinding.yaml"
"topolvm.io_logicalvolumes.yaml"
)
local namespace_scoped_manifests=(
"topolvm-controller_v1_serviceaccount.yaml"
"topolvm-csi-provisioner_rbac.authorization.k8s.io_v1_role.yaml"
"topolvm-csi-provisioner_rbac.authorization.k8s.io_v1_rolebinding.yaml"
"topolvm-csi-resizer_rbac.authorization.k8s.io_v1_role.yaml"
"topolvm-csi-resizer_rbac.authorization.k8s.io_v1_rolebinding.yaml"
"topolvm-metrics_rbac.authorization.k8s.io_v1_role.yaml"
"topolvm-metrics_rbac.authorization.k8s.io_v1_rolebinding.yaml"
"topolvm-node-metrics_v1_service.yaml"
"topolvm-node_rbac.authorization.k8s.io_v1_clusterrole.yaml"
"topolvm-node_rbac.authorization.k8s.io_v1_clusterrolebinding.yaml"
"topolvm-node_v1_serviceaccount.yaml"
"topolvm.io_logicalvolumes.yaml"
)
for m in "${manifests[@]}"; do
for m in "${cluster_scoped_manifests[@]}"; do
cp "${src}/${m}" "${dest}/" || return 1
done
for m in "${namespace_scoped_manifests[@]}"; do
cp "${src}/${m}" "${dest}/" || return 1
set_openshift_storage_ns "${dest}/${m}"
yq -i '.metadata.namespace = "openshift-storage"' "${dest}/${m}" || return 1
done
}

Expand Down