[DO NOT MERGE] assets.yaml rebase cmp#1366
Conversation
asset.yaml that lists all the files in assets/. It does not include any modifications to the manifests. Focused only on sourcing the assets (either copying from STAGING_DIR or using git restore). Its purpose is to have common place for both rebase procedure and rebase presubmit.
introduces new way of copying manifests from staging dir based on contents of assets.yaml file
changes include:
- wrapping {{ .template }} inside quotes to get correct yaml file
- formatting lvms manifests with `oc create --dry-run=client`
(includes sorting)
- changing method of creating "lvmd" ConfigMap from templating to
overriding ConfigMap's data
removed Test_renderLvmdConfig because it was testing approach based on renderTemplate() which is no longer used
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
@pmtk: GitHub didn't allow me to request PR reviews from the following users: pmtk. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
pmtk
deleted the
rebase-4.13.0-0.nightly_amd64-2023-02-13-194759_arm64-2023-02-14-014641
branch
1 participant
/cc