Skip to content

USHIFT-979: Sanitize the values of wait timeout and max boots from greenboot.conf#1526

Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
ggiguash:sanitize_greenboot_wait
Mar 19, 2023
Merged

USHIFT-979: Sanitize the values of wait timeout and max boots from greenboot.conf#1526
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
ggiguash:sanitize_greenboot_wait

Conversation

@ggiguash
Copy link
Copy Markdown
Contributor

@ggiguash ggiguash commented Mar 19, 2023

In case of an invalid input, the following messages will be logged.

Could not parse MICROSHIFT_WAIT_TIMEOUT_SEC value 'Abc': using '300' instead
GREENBOOT_MAX_BOOTS value '35' is not in the [1..9] range: using '3' instead

Closes USHIFT-979

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 19, 2023

@ggiguash: This pull request references USHIFT-979 which is a valid jira issue.

Details

In response to this:

In case of an invalid input, the following messages will be logged.

MICROSHIFT_WAIT_TIMEOUT_SEC value 'Abc' is invalid: using '300' instead
GREENBOOT_MAX_BOOTS value '35' is invalid: using '3' instead

Closes USHIFT-979

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 19, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 19, 2023

@ggiguash: This pull request references USHIFT-979 which is a valid jira issue.

Details

In response to this:

In case of an invalid input, the following messages will be logged.

MICROSHIFT_WAIT_TIMEOUT_SEC value 'Abc' is invalid: using '300' instead
GREENBOOT_MAX_BOOTS value '35' is invalid: using '3' instead

Closes USHIFT-979

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from mangelajo and oglok March 19, 2023 09:26
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2023
@ggiguash
Copy link
Copy Markdown
Contributor Author

/retest

Comment thread packaging/greenboot/functions.sh Outdated
Comment thread packaging/greenboot/functions.sh Outdated
Comment thread packaging/greenboot/functions.sh Outdated
@ggiguash ggiguash force-pushed the sanitize_greenboot_wait branch from 5cdb409 to 0c78a31 Compare March 19, 2023 14:17
@ggiguash ggiguash requested review from dhellmann and removed request for mangelajo and oglok March 19, 2023 14:18
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 19, 2023

@ggiguash: This pull request references USHIFT-979 which is a valid jira issue.

Details

In response to this:

In case of an invalid input, the following messages will be logged.

Could not parse MICROSHIFT_WAIT_TIMEOUT_SEC value 'Abc': using '300' instead
GREENBOOT_MAX_BOOTS value '35' is not in the [1..9] range: using '3' instead

Closes USHIFT-979

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Copy Markdown
Contributor

@dhellmann dhellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ggiguash
Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@ggiguash
Copy link
Copy Markdown
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 282bf50 into openshift:main Mar 19, 2023
@ggiguash
Copy link
Copy Markdown
Contributor Author

/cherrypick release-4.13

@openshift-cherrypick-robot
Copy link
Copy Markdown

@ggiguash: new pull request created: #1529

Details

In response to this:

/cherrypick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ggiguash ggiguash deleted the sanitize_greenboot_wait branch March 20, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants