Skip to content

USHIFT-1069: add script for automating ticket status based on branch#1636

Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
dhellmann:USHIFT-1069-jira-manage-ticket
Apr 13, 2023
Merged

USHIFT-1069: add script for automating ticket status based on branch#1636
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
dhellmann:USHIFT-1069-jira-manage-ticket

Conversation

@dhellmann
Copy link
Copy Markdown
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 7, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 7, 2023

@dhellmann: This pull request references USHIFT-1069 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from copejon and pmtk April 7, 2023 18:04
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2023
@dhellmann dhellmann force-pushed the USHIFT-1069-jira-manage-ticket branch from f24444e to 0d367e7 Compare April 7, 2023 18:32
@dhellmann dhellmann changed the title USHIFT-1069: add ticket for automating ticket status based on branch USHIFT-1069: add script for automating ticket status based on branch Apr 7, 2023
@dhellmann dhellmann force-pushed the USHIFT-1069-jira-manage-ticket branch from 0d367e7 to 4bbe103 Compare April 7, 2023 19:02
@dhellmann
Copy link
Copy Markdown
Contributor Author

/test e2e-openshift-conformance-reduced-arm

@dhellmann dhellmann force-pushed the USHIFT-1069-jira-manage-ticket branch 2 times, most recently from 0c6f1cc to 98d8c01 Compare April 11, 2023 19:45
Comment thread scripts/jira/start_ticket.py Outdated
Comment thread scripts/jira/start_ticket.py Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can include state = active and that should save the filtering below. There is a maxResults that defaults to 50, which for us means 150 weeks, so it will stop working next year?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the state filter fix that or are you saying I need to ask for more results?

Copy link
Copy Markdown
Contributor

@pacevedom pacevedom Apr 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I read my comment twice it looks confusing. If you use the state then its ok as long as we dont have more than 50 active sprints (which is not going to happen). Otherwise you would need to bump maxResults for the filtering below to work. Both approaches should yield the same result, so up to your preference :)
Not having an active sprint would break the script though, and that happens for a brief moment when closing a completed sprint and starting the next one.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The USHIFT board includes sprints from multiple projects, so we still need the loop. I guess I can remove the date checking portion, so I've done that.

@dhellmann dhellmann force-pushed the USHIFT-1069-jira-manage-ticket branch 2 times, most recently from 76c23cb to 07a3051 Compare April 12, 2023 18:58
Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
@dhellmann dhellmann force-pushed the USHIFT-1069-jira-manage-ticket branch from 07a3051 to a421430 Compare April 12, 2023 21:08
@dhellmann
Copy link
Copy Markdown
Contributor Author

/test e2e-openshift-conformance-reduced-arm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 12, 2023

@dhellmann: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Copy Markdown
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [dhellmann,pacevedom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants