NP-764: Enable no uplink OVN-K gateway bridge mode by pliurh · Pull Request #1692 · openshift/microshift

pliurh · 2023-04-20T13:36:44Z

Use no uplink OVN-K gateway bridge to decouple br-ex from host physical interface.
Use ovs-vsctl to create br-ex bridge instead of NM, as we don't need to run DHCP client for br-ex interface anymore.

dhellmann · 2023-04-25T20:36:41Z

@pliurh I think that if you rebase this PR on the HEAD of the main branch we will get better results from the CI jobs.

pliurh · 2023-05-04T08:29:15Z

/retest

pliurh · 2023-06-09T13:12:30Z

/retest

pliurh · 2023-06-12T02:12:10Z

/retest

anuragthehatter · 2023-06-13T15:58:52Z

/hold

This is failing on QE Ushift clusters causing node to go into NOTREADY state with error
container runtime network not ready: NetworkReady=false reason:NetworkPluginNotReady message:Network plugin returns error: No CNI configuration file in /etc/cni/net.d/.

10-ovn-kubernetes.conf is absent under /etc/cni/net.d/

pliurh · 2023-06-19T02:32:10Z

/retest

pmtk · 2023-06-19T09:45:18Z

/retest

pmtk · 2023-06-19T09:53:47Z

Today's rebase brought in changes for amd64 (it seems that we already had them for arm - introduced in 2023-06-15-173508, we had 2023-06-16-015443)

- ovn-kubernetes image-amd64 23c67c62ed1d912387791a1d8eb422b367c422dc to 5217351470aaa77bcfca04a1b6ee1ebf2bfbe7d9
  - eacdaa7 2023-06-13T09:44:38+02:00 Validate port before deleting conntrack flow
  - d829d7d 2023-06-13T09:44:21+02:00 Use no-uplink gateway bridge in compact-mode e2e test
  - f764a79 2023-06-13T09:44:16+02:00 Allow external gateway bridge without uplink port In local gateway mode

pmtk · 2023-06-19T10:15:57Z

some infra problems
/retest

pmtk · 2023-06-19T11:23:07Z

/test e2e-openshift-conformance-reduced

pliurh · 2023-06-25T03:26:21Z

Several other comments besides the inline ones:

shall we deprecate the "gatewayInterface" in this PR?

Yes.

we should no longer need to listen on the "br-ex" interface in the mdns controller.

Agree.

do we "need to" consider upgrade from default ovnk to no-uplink ovnk?

The configure-ovs.sh will handle the upgrade scenario. It will remove the NM config files and the OVS bridges and ports, then create br-ex with ovs-vsctl command.

zshi-redhat · 2023-06-25T08:17:03Z

In a fresh deployment, the service address will always be assigned to loopback device since this node network configuration runs before the InfrastructureServices controller (where CNI is started). Is it expected?

pliurh · 2023-06-26T02:20:28Z

/retest

zshi-redhat · 2023-06-26T04:06:18Z

@jcaamano Could you also take a look?
This is about integrating no-uplink ovnk gateway change in microshift, specifically the configure-ovs.sh script is updated to handle upgrade from uplink NM settings to no-uplink NM settings.

openshift-ci-robot · 2023-06-26T08:11:01Z

@pliurh: This pull request references NP-764 which is a valid jira issue.

Details

In response to this:

Use no uplink OVN-K gateway bridge to decouple br-ex from host physical interface.
Use ovs-vsctl to create br-ex bridge instead of NM, as we don't need to run DHCP client for br-ex interface anymore.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pliurh · 2023-06-26T08:11:17Z

/unhold

jcaamano · 2023-06-26T08:42:02Z

@jcaamano Could you also take a look? This is about integrating no-uplink ovnk gateway change in microshift, specifically the configure-ovs.sh script is updated to handle upgrade from uplink NM settings to no-uplink NM settings.

That part LGTM, just that small comment

pmtk

LGTM

I also verified upgrade from 4.13 to (this+#1957) and worked perfectly

pliurh · 2023-06-27T03:19:02Z

/retest

Use no uplink OVN-K gateway bridge to decouple br-ex from host physical interface. Use ovs-vsctl to create br-ex bridge instead of NM, as we don't need run DHCP client for br-ex interface anymore. Signed-off-by: Peng Liu <pliu@redhat.com>

Signed-off-by: Peng Liu <pliu@redhat.com>

zshi-redhat · 2023-06-27T09:14:23Z

/retest

pmtk · 2023-06-27T14:22:55Z

/retest

zshi-redhat · 2023-06-27T16:01:05Z

/test e2e-openshift-conformance-reduced-arm

dhellmann

This version looks good and seems to be passing the tests now that the topolvm image issue is resolved. I have one comment about some documentation, but that can (and probably should) be addressed in a simple follow-up PR, rather than requiring another iteration on this one.

The ARM tests are still a bit flakey for reasons outside of our control, so if those fail we can still merge this, unless you have reason to think the failure is related to the code.

@zshi-redhat do you want to apply the LGTM when you're happy?

dhellmann · 2023-06-27T17:28:58Z

The details in this comment thread are an important part of the design. Are they written down somewhere? If not, could you add them in a comment in this function, please? You can use a follow-up PR, since this one looks like it is almost ready to be merged.

zshi-redhat · 2023-06-28T01:39:33Z

This version looks good and seems to be passing the tests now that the topolvm image issue is resolved. I have one comment about some documentation, but that can (and probably should) be addressed in a simple follow-up PR, rather than requiring another iteration on this one.

@pliurh please file a followup PR for the documentation change.

The ARM tests are still a bit flakey for reasons outside of our control, so if those fail we can still merge this, unless you have reason to think the failure is related to the code.

agree, looking at the job history, it has 4 pass in May and zero pass in June. And the failed tests are different in each run. I will go ahead and lgtm the PR.

@zshi-redhat do you want to apply the LGTM when you're happy?

/lgtm

openshift-ci · 2023-06-28T01:39:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pliurh, zshi-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [pliurh,zshi-redhat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2023-06-28T02:57:55Z

@pliurh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-openshift-conformance-reduced-arm	`e3fc6b9`	link	false	`/test e2e-openshift-conformance-reduced-arm`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

pliurh changed the title ~~WIP~~ WIP: Use dummy interface in br-ex bridge Apr 20, 2023

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 20, 2023

openshift-ci Bot requested review from ggiguash and pacevedom April 20, 2023 13:38

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2023

pliurh force-pushed the dummy_gw branch from b53cbcd to fdb12dd Compare April 24, 2023 04:07

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 25, 2023

pliurh force-pushed the dummy_gw branch 2 times, most recently from 3745816 to 181e9fe Compare April 27, 2023 04:02

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 27, 2023

pliurh force-pushed the dummy_gw branch from 181e9fe to e0056cc Compare April 28, 2023 07:04

pliurh force-pushed the dummy_gw branch from e0056cc to 2104dbf Compare June 9, 2023 06:35

pliurh changed the title ~~WIP: Use dummy interface in br-ex bridge~~ WIP: Enable no uplink OVN-K gateway bridge mode Jun 9, 2023

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2023

pliurh force-pushed the dummy_gw branch from 2104dbf to 84bdb3c Compare June 9, 2023 10:34

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2023

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2023

pliurh force-pushed the dummy_gw branch from 84bdb3c to 7cd3a88 Compare June 15, 2023 11:54

pliurh force-pushed the dummy_gw branch from 7cd3a88 to 51259fb Compare June 19, 2023 12:25

pliurh changed the title ~~WIP: Enable no uplink OVN-K gateway bridge mode~~ Enable no uplink OVN-K gateway bridge mode Jun 19, 2023

pliurh force-pushed the dummy_gw branch 2 times, most recently from 0f181ab to baefef1 Compare June 25, 2023 06:05

zshi-redhat reviewed Jun 25, 2023

View reviewed changes

pliurh changed the title ~~Enable no uplink OVN-K gateway bridge mode~~ NP-764: Enable no uplink OVN-K gateway bridge mode Jun 26, 2023

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 26, 2023

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2023

jcaamano reviewed Jun 26, 2023

View reviewed changes

Comment thread packaging/systemd/configure-ovs.sh Outdated

pmtk reviewed Jun 26, 2023

View reviewed changes

pliurh force-pushed the dummy_gw branch from baefef1 to 22d5466 Compare June 26, 2023 14:08

zshi-redhat reviewed Jun 27, 2023

View reviewed changes

Comment thread assets/components/ovn/single-node/master/daemonset.yaml Outdated

pliurh added 2 commits June 27, 2023 11:27

Enable no uplink OVN-K gateway bridge mode

3507e2f

Use no uplink OVN-K gateway bridge to decouple br-ex from host physical interface. Use ovs-vsctl to create br-ex bridge instead of NM, as we don't need run DHCP client for br-ex interface anymore. Signed-off-by: Peng Liu <pliu@redhat.com>

Remove OVN-K config flag disableOVSInit and gatewayInterface

e3fc6b9

Signed-off-by: Peng Liu <pliu@redhat.com>

pliurh force-pushed the dummy_gw branch from 22d5466 to e3fc6b9 Compare June 27, 2023 03:32

dhellmann reviewed Jun 27, 2023

View reviewed changes

openshift-ci Bot assigned zshi-redhat Jun 28, 2023

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2023

openshift-merge-robot merged commit 70cda68 into openshift:main Jun 28, 2023

Conversation

pliurh commented Apr 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dhellmann commented Apr 25, 2023

Uh oh!

pliurh commented May 4, 2023

Uh oh!

pliurh commented Jun 9, 2023

Uh oh!

pliurh commented Jun 12, 2023

Uh oh!

anuragthehatter commented Jun 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pliurh commented Jun 19, 2023

Uh oh!

pmtk commented Jun 19, 2023

Uh oh!

pmtk commented Jun 19, 2023

Uh oh!

pmtk commented Jun 19, 2023

Uh oh!

pmtk commented Jun 19, 2023

Uh oh!

pliurh commented Jun 25, 2023

Uh oh!

Uh oh!

zshi-redhat Jun 25, 2023

Choose a reason for hiding this comment

Uh oh!

pliurh commented Jun 26, 2023

Uh oh!

zshi-redhat commented Jun 26, 2023

Uh oh!

openshift-ci-robot commented Jun 26, 2023 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pliurh commented Jun 26, 2023

Uh oh!

Uh oh!

jcaamano commented Jun 26, 2023

Uh oh!

pmtk left a comment

Choose a reason for hiding this comment

Uh oh!

pliurh commented Jun 27, 2023

Uh oh!

Uh oh!

zshi-redhat commented Jun 27, 2023

Uh oh!

pmtk commented Jun 27, 2023

Uh oh!

zshi-redhat commented Jun 27, 2023

Uh oh!

dhellmann left a comment

Choose a reason for hiding this comment

Uh oh!

dhellmann Jun 27, 2023

Choose a reason for hiding this comment

Uh oh!

zshi-redhat commented Jun 28, 2023

Uh oh!

openshift-ci Bot commented Jun 28, 2023

Uh oh!

openshift-ci Bot commented Jun 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

pliurh commented Apr 20, 2023 •

edited

Loading

anuragthehatter commented Jun 13, 2023 •

edited

Loading

openshift-ci-robot commented Jun 26, 2023 •

edited by openshift-ci Bot

Loading